From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on dcvr.yhbt.net X-Spam-Level: X-Spam-ASN: AS31976 209.132.180.0/23 X-Spam-Status: No, score=-4.0 required=3.0 tests=AWL,BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,RCVD_IN_DNSWL_HI shortcircuit=no autolearn=ham autolearn_force=no version=3.4.2 Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by dcvr.yhbt.net (Postfix) with ESMTP id 5E5EC211B5 for ; Tue, 12 Feb 2019 00:27:09 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727811AbfBLA1I (ORCPT ); Mon, 11 Feb 2019 19:27:08 -0500 Received: from cloud.peff.net ([104.130.231.41]:40880 "HELO cloud.peff.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with SMTP id S1727297AbfBLA1H (ORCPT ); Mon, 11 Feb 2019 19:27:07 -0500 Received: (qmail 19520 invoked by uid 109); 12 Feb 2019 00:27:09 -0000 Received: from Unknown (HELO peff.net) (10.0.1.2) by cloud.peff.net (qpsmtpd/0.94) with SMTP; Tue, 12 Feb 2019 00:27:09 +0000 Authentication-Results: cloud.peff.net; auth=none Received: (qmail 19404 invoked by uid 111); 12 Feb 2019 00:27:17 -0000 Received: from sigill.intra.peff.net (HELO sigill.intra.peff.net) (10.0.0.7) by peff.net (qpsmtpd/0.94) with (ECDHE-RSA-AES256-GCM-SHA384 encrypted) SMTP; Mon, 11 Feb 2019 19:27:17 -0500 Authentication-Results: peff.net; auth=none Received: by sigill.intra.peff.net (sSMTP sendmail emulation); Mon, 11 Feb 2019 19:27:05 -0500 Date: Mon, 11 Feb 2019 19:27:05 -0500 From: Jeff King To: Junio C Hamano Cc: Duy Nguyen , "Randall S. Becker" , Git Mailing List Subject: Re: [Breakage] 2.20.0-rc0 t1404: test_i18ngrep reports 1 instead of 0 on NonStop in one case Message-ID: <20190212002705.GD13301@sigill.intra.peff.net> References: <000801d4c174$05b76860$11263920$@nexbridge.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: Sender: git-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: git@vger.kernel.org On Mon, Feb 11, 2019 at 01:07:15PM -0800, Junio C Hamano wrote: > >> test_i18ngrep "Unable to create $Q.*packed-refs.lock$Q: File exists" err > > > > The message does not match, does it? Here we grep for "File exists" > > but the message you showed says "File already exists". > > Hmph, this is from strerror(), right? > > The question is if we should be using grep to match on strerror() > result in the C locale. Yeah, I agree that's questionable. And I'm mildly surprised it hasn't been a problem before now. > Do we really care that the reason of the > failure is due to EEXIST for this particular test? Hmm. We care to _some_ degree, since that's the condition we set up for making sure that update-ref cannot take the lock. But it would probably be fine to just confirm that we failed to take the lock. And there, checking for just "Unable to create $Q.*packed-refs.lock" would be sufficient. -Peff