git.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: "Ævar Arnfjörð Bjarmason" <avarab@gmail.com>
To: git@vger.kernel.org
Cc: "Junio C Hamano" <gitster@pobox.com>, "Jeff King" <peff@peff.net>,
	"Nguyễn Thái Ngọc Duy" <pclouds@gmail.com>,
	"Thomas Gummerer" <t.gummerer@gmail.com>,
	"Beat Bolli" <dev+git@drbeat.li>,
	"Lars Schneider" <larsxschneider@gmail.com>,
	"Matthieu Moy" <Matthieu.Moy@imag.fr>,
	"Ævar Arnfjörð Bjarmason" <avarab@gmail.com>
Subject: [PATCH v2 0/6] Makefile: allow for combining DEVELOPER= and CFLAGS="..."
Date: Fri, 22 Feb 2019 15:41:21 +0100	[thread overview]
Message-ID: <20190222144127.32248-1-avarab@gmail.com> (raw)
In-Reply-To: <20190222105658.26831-1-avarab@gmail.com>

This fixes a long-standing annoyance of mine of not being able to set
my own CFLAGS combined with DEVELOPER="...".

There *should* be no other functional changes, but I'm moving around
some core Makefile logic, so this needs to be carefully reviewed.

I've tried installing with this, setting flags involved etc. It works
as expected, but we have no tests for the Makefile itself, so I might
have missed something.

I sent a stand-alone "Makefile: remove an out-of-date comment"[1] a
bit too soon as it turns out. I thought it could be stand-alone, but
as it turns out I needed to move some code adjacent to it. It would
conflict with this, so it's now bundled up with it as a v2.

1. https://public-inbox.org/git/20190222105658.26831-1-avarab@gmail.com/

Ævar Arnfjörð Bjarmason (6):
  Makefile: remove an out-of-date comment
  Makefile: move "strip" assignment down from flags
  Makefile: add/remove comments at top and tweak whitespace
  Makefile: Move *_LIBS assignment into its own section
  Makefile: move the setting of *FLAGS closer to "include"
  Makefile: allow for combining DEVELOPER=1 and CFLAGS="..."

 Makefile       | 63 ++++++++++++++++++++++++++------------------------
 config.mak.dev | 44 +++++++++++++++++------------------
 2 files changed, 55 insertions(+), 52 deletions(-)

-- 
2.21.0.rc2.1.g2d5e20a900.dirty


  reply	other threads:[~2019-02-22 14:41 UTC|newest]

Thread overview: 20+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-02-22 10:56 [PATCH] Makefile: remove an out-of-date comment Ævar Arnfjörð Bjarmason
2019-02-22 14:41 ` Ævar Arnfjörð Bjarmason [this message]
2019-02-22 15:16   ` [PATCH v2 0/6] Makefile: allow for combining DEVELOPER= and CFLAGS="..." Jeff King
2019-02-22 21:59     ` Ævar Arnfjörð Bjarmason
2019-02-23 13:22       ` Jeff King
2019-02-22 14:41 ` [PATCH v2 1/6] Makefile: remove an out-of-date comment Ævar Arnfjörð Bjarmason
2019-02-22 14:41 ` [PATCH v2 2/6] Makefile: move "strip" assignment down from flags Ævar Arnfjörð Bjarmason
2019-02-22 15:18   ` Jeff King
2019-02-22 21:58     ` Ramsay Jones
2019-02-23 13:23       ` Jeff King
2019-02-22 14:41 ` [PATCH v2 3/6] Makefile: add/remove comments at top and tweak whitespace Ævar Arnfjörð Bjarmason
2019-02-22 14:41 ` [PATCH v2 4/6] Makefile: Move *_LIBS assignment into its own section Ævar Arnfjörð Bjarmason
2019-02-22 15:21   ` Jeff King
2019-02-22 15:49   ` Eric Sunshine
2019-02-22 14:41 ` [PATCH v2 5/6] Makefile: move the setting of *FLAGS closer to "include" Ævar Arnfjörð Bjarmason
2019-02-22 23:19   ` Junio C Hamano
2019-02-22 14:41 ` [PATCH v2 6/6] Makefile: allow for combining DEVELOPER=1 and CFLAGS="..." Ævar Arnfjörð Bjarmason
2019-02-22 15:29   ` Jeff King
2019-02-22 23:23   ` Junio C Hamano
2019-02-22 15:09 ` [PATCH] Makefile: remove an out-of-date comment Jeff King

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20190222144127.32248-1-avarab@gmail.com \
    --to=avarab@gmail.com \
    --cc=Matthieu.Moy@imag.fr \
    --cc=dev+git@drbeat.li \
    --cc=git@vger.kernel.org \
    --cc=gitster@pobox.com \
    --cc=larsxschneider@gmail.com \
    --cc=pclouds@gmail.com \
    --cc=peff@peff.net \
    --cc=t.gummerer@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).