From: Jeff King <peff@peff.net>
To: Todd Zullinger <tmz@pobox.com>
Cc: "Randall S. Becker" <rsbecker@nexbridge.com>,
git@vger.kernel.org, Jonathan Nieder <jrnieder@gmail.com>
Subject: Re: [Suggestion] Add Skip for t9020
Date: Fri, 22 Feb 2019 10:30:54 -0500 [thread overview]
Message-ID: <20190222153054.GD21524@sigill.intra.peff.net> (raw)
In-Reply-To: <20190221205837.GX16125@zaya.teonanacatl.net>
On Thu, Feb 21, 2019 at 03:58:37PM -0500, Todd Zullinger wrote:
> > While this is a bit of a hack, it might be useful for skipping t9020 in
> > environments where the svn.remote package is not installed. I can make this
> > into a patch if this style is reasonable - guessing probably not and that
> > the REMOTE_SVN test should go elsewhere if it is called that.
>
> Jeff King sent an RFC patch which would remove this test and
> the rest of the vcs-svn experiment in August[1]. Jonathan
> Nieder replied as one user who would rather see it moved to
> contrib/, so it was held off.
>
> Whether that has any impact on adding a way to skip all the
> tests here, I don't know. Maybe it's a gentle nudge in
> favor of moving them to contrib?
I still hoped we could ditch them completely. :) As part of my
-Wunused-parameter patches, I found that was an easy way to get rid of
some warnings. But I'd be OK if they were in contrib/, too.
-Peff
next prev parent reply other threads:[~2019-02-22 15:30 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-02-21 20:28 [Suggestion] Add Skip for t9020 Randall S. Becker
2019-02-21 20:58 ` Todd Zullinger
2019-02-22 15:30 ` Jeff King [this message]
2019-02-22 0:46 ` Jonathan Nieder
2019-02-22 2:46 ` Randall S. Becker
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190222153054.GD21524@sigill.intra.peff.net \
--to=peff@peff.net \
--cc=git@vger.kernel.org \
--cc=jrnieder@gmail.com \
--cc=rsbecker@nexbridge.com \
--cc=tmz@pobox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).