From: Jeff King <peff@peff.net>
To: Alban Gruin <alban.gruin@gmail.com>
Cc: Git Mailing List <git@vger.kernel.org>
Subject: Re: [RFC PATCH 1/4] name-rev: improve name_rev() memory usage
Date: Fri, 1 Mar 2019 13:44:57 -0500 [thread overview]
Message-ID: <20190301184457.GE30847@sigill.intra.peff.net> (raw)
In-Reply-To: <20190301175024.17337-2-alban.gruin@gmail.com>
On Fri, Mar 01, 2019 at 06:50:21PM +0100, Alban Gruin wrote:
> name_rev() is a recursive function. For each commit, it allocates the
> name of its parents, and call itself. A parent may not use a name for
> multiple reasons, but in any case, the name will not be released. On a
> repository with a lot of branches, tags, remotes, and commits, it can
> use more than 2GB of RAM.
I don't know name-rev that well, so I didn't look super carefully at
your patch. But if it's recursive in history, that's almost certainly
going to be a problem for some histories on some platforms. We've had to
de-recursify several other algorithms (e.g., "tag --contains") because
of stack space issues.
Which isn't to say what you're doing here might not be separately
useful, but just know that in the long run that's probably where we'd
need to take this.
-Peff
next prev parent reply other threads:[~2019-03-01 18:45 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-03-01 17:50 [RFC PATCH 0/4] name-rev: improve memory usage Alban Gruin
2019-03-01 17:50 ` [RFC PATCH 1/4] name-rev: improve name_rev() " Alban Gruin
2019-03-01 18:00 ` Eric Sunshine
2019-03-01 18:44 ` Jeff King [this message]
2019-03-02 21:28 ` Johannes Schindelin
2019-03-01 17:50 ` [RFC PATCH 2/4] commit-list: add a function to check if a commit is in a list Alban Gruin
2019-03-01 17:50 ` [RFC PATCH 3/4] name-rev: check if a commit should be named before naming it Alban Gruin
2019-03-01 18:05 ` Eric Sunshine
2019-03-01 18:22 ` Alban Gruin
2019-03-01 18:37 ` Jeff King
2019-03-01 17:50 ` [RFC PATCH 4/4] name-rev: avoid naming from a ref if it’s not a descendant of any commit Alban Gruin
2019-03-01 18:07 ` Eric Sunshine
2019-03-03 19:33 ` Christian Couder
2019-03-03 19:46 ` Christian Couder
2019-03-03 20:27 ` Alban Gruin
2019-03-01 18:42 ` [RFC PATCH 0/4] name-rev: improve memory usage Jeff King
2019-03-01 19:14 ` Alban Gruin
2019-03-01 19:39 ` Jeff King
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190301184457.GE30847@sigill.intra.peff.net \
--to=peff@peff.net \
--cc=alban.gruin@gmail.com \
--cc=git@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).