From: "Nguyễn Thái Ngọc Duy" <pclouds@gmail.com>
To: phillip.wood123@gmail.com
Cc: git@vger.kernel.org, pclouds@gmail.com,
phillip.wood@dunelm.org.uk, Junio C Hamano <gitster@pobox.com>,
Johannes Schindelin <Johannes.Schindelin@gmx.de>
Subject: [PATCH 0/3] Fix refs/rewritten not show up in for-each-ref
Date: Thu, 7 Mar 2019 19:29:14 +0700 [thread overview]
Message-ID: <20190307122917.12811-1-pclouds@gmail.com> (raw)
In-Reply-To: <ec707cbb-96e8-f26f-3d69-b69d29b31737@gmail.com>
Apparently there is one corner case where refs/rewritten/* may not show
up in for-each-ref in multiple worktree setup. This is because the
per-worktree classification has to be done in three places (my bad!)
and Johannes only updated one.
This should fix it (and it also fixes refs/worktree/ not showing up
under the same condition because I'm an idiot who does not know how to
test).
Nguyễn Thái Ngọc Duy (3):
files-backend.c: factor out per-worktree code in loose_fill_ref_dir()
files-backend.c: reduce duplication in
add_per_worktree_entries_to_dir()
Make sure refs/rewritten/ is per-worktree
path.c | 3 +++
refs/files-backend.c | 50 ++++++++++++++++++++++------------------
t/t1415-worktree-refs.sh | 35 ++++++++++++++++++++++++++++
3 files changed, 66 insertions(+), 22 deletions(-)
--
2.21.0.rc1.337.gdf7f8d0522
next prev parent reply other threads:[~2019-03-07 12:29 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-03-06 15:57 [BUG] worktree local refs weirdness Phillip Wood
2019-03-07 9:38 ` Phillip Wood
2019-03-07 9:46 ` Duy Nguyen
2019-03-07 10:20 ` Duy Nguyen
2019-03-07 12:29 ` Nguyễn Thái Ngọc Duy [this message]
2019-03-07 12:29 ` [PATCH 1/3] files-backend.c: factor out per-worktree code in loose_fill_ref_dir() Nguyễn Thái Ngọc Duy
2019-03-07 12:29 ` [PATCH 2/3] files-backend.c: reduce duplication in add_per_worktree_entries_to_dir() Nguyễn Thái Ngọc Duy
2019-03-07 14:44 ` Phillip Wood
2019-03-07 12:29 ` [PATCH 3/3] Make sure refs/rewritten/ is per-worktree Nguyễn Thái Ngọc Duy
2019-03-07 14:45 ` Phillip Wood
2019-03-07 14:51 ` Duy Nguyen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190307122917.12811-1-pclouds@gmail.com \
--to=pclouds@gmail.com \
--cc=Johannes.Schindelin@gmx.de \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
--cc=phillip.wood123@gmail.com \
--cc=phillip.wood@dunelm.org.uk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).