From: Jeff King <peff@peff.net>
To: Junio C Hamano <gitster@pobox.com>
Cc: Thomas Gummerer <t.gummerer@gmail.com>,
Denton Liu <liu.denton@gmail.com>,
Git Mailing List <git@vger.kernel.org>,
Paul-Sebastian Ungureanu <ungureanupaulsebastian@gmail.com>,
Joel Teichroeb <joel@teichroeb.net>,
Johannes Schindelin <Johannes.Schindelin@gmx.de>,
Matthew Kraai <mkraai@its.jnj.com>
Subject: Re: [PATCH v2] stash: setup default diff output format if necessary
Date: Thu, 21 Mar 2019 23:48:37 -0400 [thread overview]
Message-ID: <20190322034837.GA20091@sigill.intra.peff.net> (raw)
In-Reply-To: <xmqqtvfvr3oi.fsf@gitster-ct.c.googlers.com>
On Fri, Mar 22, 2019 at 12:25:17PM +0900, Junio C Hamano wrote:
> > There is a "set_default" callback that was added by 6c374008b1
> > (diff_opt: track whether flags have been set explicitly, 2013-05-10),
> > but it looks like it was never actually used. I think the theory is that
> > cases like this could do their tweaking in such a callback. But I think
> > it makes sense to follow the lead of builtin/diff.c for the immediate
> > fix, and we can look at using set_default as a separate topic.
>
> I agree with the conclusion. I wouldn't be surprised if this is one
> of the things that was once used but left behind when the last
> caller disappeared, though.
I wondered, too, but `git log --pickaxe-regex -S'set_default[^_]'` seems
to think it was purely aspirational. :)
That calls for a little extra caution when starting to use it (because
it has not really been tested), but from a quick look I cannot see how
it would go wrong.
-Peff
prev parent reply other threads:[~2019-03-22 3:48 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-03-19 19:05 [REGRESSION ps/stash-in-c] git stash show -v Denton Liu
2019-03-19 23:18 ` Thomas Gummerer
2019-03-20 1:00 ` Junio C Hamano
2019-03-20 21:45 ` Thomas Gummerer
2019-03-20 1:04 ` Junio C Hamano
2019-03-20 5:04 ` Jeff King
2019-03-20 9:30 ` Duy Nguyen
2019-03-20 21:59 ` Thomas Gummerer
2019-03-20 22:49 ` [PATCH v2] stash: setup default diff output format if necessary Thomas Gummerer
2019-03-20 23:04 ` Denton Liu
2019-03-20 23:09 ` Denton Liu
2019-03-28 20:45 ` Thomas Gummerer
2019-03-21 9:51 ` Jeff King
2019-03-22 3:25 ` Junio C Hamano
2019-03-22 3:48 ` Jeff King [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190322034837.GA20091@sigill.intra.peff.net \
--to=peff@peff.net \
--cc=Johannes.Schindelin@gmx.de \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
--cc=joel@teichroeb.net \
--cc=liu.denton@gmail.com \
--cc=mkraai@its.jnj.com \
--cc=t.gummerer@gmail.com \
--cc=ungureanupaulsebastian@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).