From: Jeff King <peff@peff.net>
To: Jonathan Tan <jonathantanmy@google.com>
Cc: git@vger.kernel.org, gitster@pobox.com
Subject: Re: [PATCH v2] t5551: mark half-auth no-op fetch test as v0-only
Date: Sat, 23 Mar 2019 03:05:48 -0400 [thread overview]
Message-ID: <20190323070548.GA24065@sigill.intra.peff.net> (raw)
In-Reply-To: <20190322190139.151189-1-jonathantanmy@google.com>
On Fri, Mar 22, 2019 at 12:01:39PM -0700, Jonathan Tan wrote:
> When using protocol v0, upload-pack over HTTP permits a "half-auth"
> configuration in which, at the web server layer, the info/refs path is
> not protected by authentication but the git-upload-pack path is, so that
> a user can perform fetches that do not download any objects without
> authentication, but still needs authentication to download objects.
>
> But protocol v2 does not support this, because both ref and pack are
> obtained from the git-upload-pack path.
>
> Mark the test verifying this behavior as protocol v0-only, with a
> description of what needs to be done to make v2 support this.
Thanks, this looks like a fine solution to me.
I do not really expect anyone will ever get around to this NEEDSWORK,
but we can see. :)
-Peff
next prev parent reply other threads:[~2019-03-23 7:05 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-03-21 17:47 [RFC PATCH] t5551: delete auth-for-pack-but-not-refs test Jonathan Tan
2019-03-21 19:55 ` Jeff King
2019-03-21 20:02 ` Jeff King
2019-03-21 20:24 ` Jonathan Tan
2019-03-21 21:48 ` Jeff King
2019-03-21 22:36 ` Jonathan Tan
2019-03-22 2:20 ` Junio C Hamano
2019-03-22 17:20 ` Jonathan Tan
2019-03-22 19:01 ` [PATCH v2] t5551: mark half-auth no-op fetch test as v0-only Jonathan Tan
2019-03-23 7:05 ` Jeff King [this message]
2019-04-06 11:31 ` Jonathan Nieder
2019-04-08 17:01 ` Jonathan Tan
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190323070548.GA24065@sigill.intra.peff.net \
--to=peff@peff.net \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
--cc=jonathantanmy@google.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).