From: Denton Liu <liu.denton@gmail.com>
To: Junio C Hamano <gitster@pobox.com>
Cc: git@vger.kernel.org
Subject: Re: What's cooking in git.git (Apr 2019, #02; Wed, 10)
Date: Tue, 9 Apr 2019 11:22:47 -0700 [thread overview]
Message-ID: <20190409182247.GA7317@dev-l> (raw)
In-Reply-To: <xmqqr2ab2gs6.fsf@gitster-ct.c.googlers.com>
Hi Junio,
On Wed, Apr 10, 2019 at 03:08:09AM +0900, Junio C Hamano wrote:
> * dl/submodule-set-branch (2019-02-08) 3 commits
> - submodule: teach set-branch subcommand
> - submodule--helper: teach config subcommand --unset
> - git-submodule.txt: "--branch <branch>" option defaults to 'master'
>
> "git submodule" learns "set-branch" subcommand that allows the
> submodule.*.branch settings to be modified.
>
> Needs sign-off on the tip commit; other than that it seems OK to be in 'next'.
This has been here for a while. Did you need my explicit sign-off for
this? If that's the case, here you go:
Signed-off-by: Denton Liu <liu.denton@gmail.com>
> * dl/merge-cleanup-scissors-fix (2019-03-21) 11 commits
> - cherry-pick/revert: add scissors line on merge conflict
> - sequencer.c: define describe_cleanup_mode
> - merge: add scissors line on merge conflict
> - merge: cleanup messages like commit
> - sequencer.c: remove duplicate code
> - parse-options.h: extract common --cleanup option
> - commit: extract cleanup_mode functions to sequencer
> - t7502: clean up style
> - t7604: clean up style
> - t3507: clean up style
> - t7600: clean up style
>
> The list of conflicted paths shown in the editor while concluding a
> conflicted merge was shown above the scissors line when the
> clean-up mode is set to "scissors", even though it was commented
> out just like the list of updated paths and other information to
> help the user explain the merge better.
>
> Needs review.
> cf. <cover.1553150827.git.liu.denton@gmail.com> (v9)
Phillip Wood left some comments for me here[1] and off-list. I haven't
had time to address his concerns yet but whenever I do, I'll probably be
sending another re-roll.
Thanks,
Denton
[1]: https://public-inbox.org/git/69e3e5b7-58ec-4507-bc5c-c162393368c4@gmail.com/
next prev parent reply other threads:[~2019-04-09 18:22 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-04-09 18:08 What's cooking in git.git (Apr 2019, #02; Wed, 10) Junio C Hamano
2019-04-09 18:22 ` Denton Liu [this message]
2019-04-10 3:09 ` Junio C Hamano
2019-04-09 19:18 ` Thomas Gummerer
2019-04-10 3:01 ` Junio C Hamano
2019-04-10 20:45 ` Thomas Gummerer
2019-04-10 22:13 ` Johannes Schindelin
2019-04-10 0:46 ` Todd Zullinger
2019-04-10 10:12 ` Phillip Wood
2019-04-10 22:15 ` Johannes Schindelin
2019-04-10 18:29 ` Mazo, Andrey
2019-04-10 21:51 ` nd/switch-and-restore, was " Johannes Schindelin
2019-04-10 21:56 ` dl/warn-tagging-a-tag, " Johannes Schindelin
2019-04-12 1:51 ` Junio C Hamano
2019-04-10 22:32 ` jh/trace2-sid-fix, " Johannes Schindelin
2019-04-11 15:06 ` Christian Couder
2019-04-14 3:55 ` Junio C Hamano
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190409182247.GA7317@dev-l \
--to=liu.denton@gmail.com \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).