* [PATCH] t/lib-httpd: pass LSAN_OPTIONS through apache
@ 2019-05-07 22:30 Jeff King
2019-05-07 22:45 ` Josh Steadmon
0 siblings, 1 reply; 2+ messages in thread
From: Jeff King @ 2019-05-07 22:30 UTC (permalink / raw)
To: git; +Cc: Ævar Arnfjörð Bjarmason, Josh Steadmon, git,
stolee
Just as we instruct Apache to pass through ASAN_OPTIONS (so that
server-side Git programs it spawns will respect our options while
running the tests), we should do the same with LSAN_OPTIONS. Otherwise
trying to collect a list of leaks like:
export LSAN_OPTIONS=exitcode=0:log_path=/tmp/lsan
make SANITIZE=leak test
won't work for http tests (the server-side programs won't log their
leaks to the right place, and they'll prematurely die, producing a
spurious test failure).
Signed-off-by: Jeff King <peff@peff.net>
---
Found this after giving similar advice in
https://public-inbox.org/git/20190507222601.GA976@sigill.intra.peff.net/
t/lib-httpd/apache.conf | 1 +
1 file changed, 1 insertion(+)
diff --git a/t/lib-httpd/apache.conf b/t/lib-httpd/apache.conf
index 06a81b54c7..5c1c86c193 100644
--- a/t/lib-httpd/apache.conf
+++ b/t/lib-httpd/apache.conf
@@ -76,6 +76,7 @@ PassEnv GIT_VALGRIND
PassEnv GIT_VALGRIND_OPTIONS
PassEnv GNUPGHOME
PassEnv ASAN_OPTIONS
+PassEnv LSAN_OPTIONS
PassEnv GIT_TRACE
PassEnv GIT_CONFIG_NOSYSTEM
PassEnv GIT_TEST_SIDEBAND_ALL
--
2.21.0.1314.g224b191707
^ permalink raw reply related [flat|nested] 2+ messages in thread* Re: [PATCH] t/lib-httpd: pass LSAN_OPTIONS through apache
2019-05-07 22:30 [PATCH] t/lib-httpd: pass LSAN_OPTIONS through apache Jeff King
@ 2019-05-07 22:45 ` Josh Steadmon
0 siblings, 0 replies; 2+ messages in thread
From: Josh Steadmon @ 2019-05-07 22:45 UTC (permalink / raw)
To: Jeff King; +Cc: git, Ævar Arnfjörð Bjarmason, stolee
On 2019.05.07 18:30, Jeff King wrote:
> Just as we instruct Apache to pass through ASAN_OPTIONS (so that
> server-side Git programs it spawns will respect our options while
> running the tests), we should do the same with LSAN_OPTIONS. Otherwise
> trying to collect a list of leaks like:
>
> export LSAN_OPTIONS=exitcode=0:log_path=/tmp/lsan
> make SANITIZE=leak test
>
> won't work for http tests (the server-side programs won't log their
> leaks to the right place, and they'll prematurely die, producing a
> spurious test failure).
>
> Signed-off-by: Jeff King <peff@peff.net>
> ---
> Found this after giving similar advice in
>
> https://public-inbox.org/git/20190507222601.GA976@sigill.intra.peff.net/
>
> t/lib-httpd/apache.conf | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/t/lib-httpd/apache.conf b/t/lib-httpd/apache.conf
> index 06a81b54c7..5c1c86c193 100644
> --- a/t/lib-httpd/apache.conf
> +++ b/t/lib-httpd/apache.conf
> @@ -76,6 +76,7 @@ PassEnv GIT_VALGRIND
> PassEnv GIT_VALGRIND_OPTIONS
> PassEnv GNUPGHOME
> PassEnv ASAN_OPTIONS
> +PassEnv LSAN_OPTIONS
> PassEnv GIT_TRACE
> PassEnv GIT_CONFIG_NOSYSTEM
> PassEnv GIT_TEST_SIDEBAND_ALL
> --
> 2.21.0.1314.g224b191707
Looks good to me.
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2019-05-07 22:45 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2019-05-07 22:30 [PATCH] t/lib-httpd: pass LSAN_OPTIONS through apache Jeff King
2019-05-07 22:45 ` Josh Steadmon
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).