Git development
 help / color / mirror / Atom feed
From: Thomas Gummerer <t.gummerer@gmail.com>
To: Andrei Rybak <rybak.a.v@gmail.com>
Cc: Mike Hommey <mh@glandium.org>,
	git@vger.kernel.org, ungureanupaulsebastian@gmail.com
Subject: Re: [PATCH] stash: fix show referencing stash index
Date: Mon, 17 Jun 2019 07:03:11 +0100	[thread overview]
Message-ID: <20190617060311.GE28007@hank.intra.tgummerer.com> (raw)
In-Reply-To: <78f730f1-d40e-1415-b6a6-4a1b224e7818@gmail.com>

On 06/15, Andrei Rybak wrote:
> On 6/15/19 1:26 PM, Thomas Gummerer wrote:
> > diff --git a/t/t3903-stash.sh b/t/t3903-stash.sh
> > index ea30d5f6a0..3973cbda0e 100755
> > --- a/t/t3903-stash.sh
> > +++ b/t/t3903-stash.sh
> > @@ -708,6 +708,24 @@ test_expect_success 'invalid ref of the form "n", n >= N' '
> >  	git stash drop
> >  '
> >  
> > +test_expect_success 'valid ref of the form "n", n >= N' '
> 
> If ref is valid, 'n < N' was probably meant here.

Yes, indeed.  Thanks!

  reply	other threads:[~2019-06-17  6:03 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-06-14  7:42 `git stash <command> <n>` stopped working in 2.22.0 Mike Hommey
2019-06-15 11:26 ` [PATCH] stash: fix show referencing stash index Thomas Gummerer
2019-06-15 13:02   ` Andrei Rybak
2019-06-17  6:03     ` Thomas Gummerer [this message]
2019-06-24 20:29   ` Mike Hommey

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20190617060311.GE28007@hank.intra.tgummerer.com \
    --to=t.gummerer@gmail.com \
    --cc=git@vger.kernel.org \
    --cc=mh@glandium.org \
    --cc=rybak.a.v@gmail.com \
    --cc=ungureanupaulsebastian@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox