From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on dcvr.yhbt.net X-Spam-Level: X-Spam-ASN: AS31976 209.132.180.0/23 X-Spam-Status: No, score=-3.9 required=3.0 tests=AWL,BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,RCVD_IN_DNSWL_HI, SPF_HELO_NONE,SPF_NONE shortcircuit=no autolearn=ham autolearn_force=no version=3.4.2 Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by dcvr.yhbt.net (Postfix) with ESMTP id EB7281F462 for ; Thu, 20 Jun 2019 08:48:45 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726081AbfFTIso (ORCPT ); Thu, 20 Jun 2019 04:48:44 -0400 Received: from cloud.peff.net ([104.130.231.41]:45598 "HELO cloud.peff.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with SMTP id S1725875AbfFTIso (ORCPT ); Thu, 20 Jun 2019 04:48:44 -0400 Received: (qmail 17928 invoked by uid 109); 20 Jun 2019 08:48:44 -0000 Received: from Unknown (HELO peff.net) (10.0.1.2) by cloud.peff.net (qpsmtpd/0.94) with SMTP; Thu, 20 Jun 2019 08:48:44 +0000 Authentication-Results: cloud.peff.net; auth=none Received: (qmail 13729 invoked by uid 111); 20 Jun 2019 08:49:33 -0000 Received: from sigill.intra.peff.net (HELO sigill.intra.peff.net) (10.0.0.7) by peff.net (qpsmtpd/0.94) with (ECDHE-RSA-AES256-GCM-SHA384 encrypted) SMTP; Thu, 20 Jun 2019 04:49:33 -0400 Authentication-Results: peff.net; auth=none Received: by sigill.intra.peff.net (sSMTP sendmail emulation); Thu, 20 Jun 2019 04:48:42 -0400 Date: Thu, 20 Jun 2019 04:48:42 -0400 From: Jeff King To: Christian Couder Cc: git@vger.kernel.org, Junio C Hamano , Derrick Stolee , Johannes Schindelin , Christian Couder Subject: Re: [PATCH 1/2] object-store: introduce OBJECT_INFO_NO_FETCH_IF_MISSING Message-ID: <20190620084842.GB3952@sigill.intra.peff.net> References: <20190620083026.14524-1-chriscool@tuxfamily.org> <20190620083026.14524-2-chriscool@tuxfamily.org> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: <20190620083026.14524-2-chriscool@tuxfamily.org> Sender: git-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: git@vger.kernel.org On Thu, Jun 20, 2019 at 10:30:25AM +0200, Christian Couder wrote: > The fetch_if_missing global variable should be replaced as much > as possible by passing a flag to oid_object_info_extended(). > > The existing OBJECT_INFO_FOR_PREFETCH unfortunately conflates > both a "no fetch if missing" meaning with OBJECT_INFO_QUICK > which is about retrying packed storage. > > Let's disambiguate that by adding a new explicit > OBJECT_INFO_NO_FETCH_IF_MISSING flag. I think this patch is obsoleted by Stolee's 31f5256c82 (sha1-file: split OBJECT_INFO_FOR_PREFETCH, 2019-05-28), which I think just made it to master in the last day or so. There it's called OBJECT_INFO_SKIP_FETCH_OBJECT, so your 2/2 will need to be tweaked. -Peff