Git development
 help / color / mirror / Atom feed
From: Emily Shaffer <emilyshaffer@google.com>
To: Christian Couder <christian.couder@gmail.com>
Cc: git@vger.kernel.org, Junio C Hamano <gitster@pobox.com>,
	Christian Couder <chriscool@tuxfamily.org>
Subject: Re: [PATCH] doc: improve usage string in MyFirstContribution
Date: Thu, 20 Jun 2019 14:29:22 -0700	[thread overview]
Message-ID: <20190620212922.GB87385@google.com> (raw)
In-Reply-To: <20190619221315.7343-1-chriscool@tuxfamily.org>

On Thu, Jun 20, 2019 at 12:13:15AM +0200, Christian Couder wrote:
>  SYNOPSIS
>  --------
>  [verse]
> -'git-psuh'
> +'git-psuh <arg>...'

It doesn't require 1 or more args - you can run it with no args. So it
might be better suited to state the args as optional:

  'git psuh [arg]...'

>  ----
>  static const char * const psuh_usage[] = {
> -	N_("git psuh"),
> +	N_("git psuh <arg>..."),

...and here too.

 - Emily

  reply	other threads:[~2019-06-20 21:29 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-06-19 22:13 [PATCH] doc: improve usage string in MyFirstContribution Christian Couder
2019-06-20 21:29 ` Emily Shaffer [this message]
2019-06-21 10:43   ` Christian Couder
2019-06-21 16:37     ` Eric Sunshine
2019-06-21 17:18       ` Junio C Hamano
2019-06-21 19:00         ` Eric Sunshine

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20190620212922.GB87385@google.com \
    --to=emilyshaffer@google.com \
    --cc=chriscool@tuxfamily.org \
    --cc=christian.couder@gmail.com \
    --cc=git@vger.kernel.org \
    --cc=gitster@pobox.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox