From: Jeff King <peff@peff.net>
To: "Pugh, Logan" <Logan.Pugh@austintexas.gov>
Cc: "git@vger.kernel.org" <git@vger.kernel.org>,
"liu.denton@gmail.com" <liu.denton@gmail.com>
Subject: Re: [2.22.0] difftool no longer passes through to git diff if diff.tool is unset
Date: Wed, 26 Jun 2019 14:08:21 -0400 [thread overview]
Message-ID: <20190626180821.GA23857@sigill.intra.peff.net> (raw)
In-Reply-To: <BL0PR0901MB4466FF7338C085ADBBF594898AE30@BL0PR0901MB4466.namprd09.prod.outlook.com>
On Tue, Jun 25, 2019 at 11:09:08PM +0000, Pugh, Logan wrote:
> > Or in your case I suppose even better would just be an
> > option like "--if-not-configured-just-use-regular-diff". Then it would
> > do what you want, without impacting users who do want the interactive
> > setup.
>
> If such an option was considered I would be in favor of it. Maybe call
> it "--no-tutorial" or perhaps "--diff-fallback".
>
> But having fixed my app, I'm content with the status quo too, now.
Yeah, those are definitely better names. :)
I think we're on the same page about a good path forward, then. I don't
plan to work on this myself, but maybe it would be a good #leftoverbits
candidate for somebody wanting to get started on modifying Git.
-Peff
prev parent reply other threads:[~2019-06-26 18:08 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-06-19 23:54 [2.22.0] difftool no longer passes through to git diff if diff.tool is unset Pugh, Logan
2019-06-20 1:17 ` Denton Liu
2019-06-20 2:45 ` Denton Liu
2019-06-20 5:21 ` Jeff King
2019-06-20 19:29 ` Pugh, Logan
2019-06-25 21:35 ` Jeff King
2019-06-25 23:09 ` Pugh, Logan
2019-06-26 18:08 ` Jeff King [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190626180821.GA23857@sigill.intra.peff.net \
--to=peff@peff.net \
--cc=Logan.Pugh@austintexas.gov \
--cc=git@vger.kernel.org \
--cc=liu.denton@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).