From: Jeff King <peff@peff.net>
To: git@vger.kernel.org
Cc: Taylor Blau <me@ttaylorr.com>
Subject: Re: [PATCH] check_everything_connected: assume alternate ref tips are valid
Date: Fri, 28 Jun 2019 06:18:58 -0400 [thread overview]
Message-ID: <20190628101858.GA23052@sigill.intra.peff.net> (raw)
In-Reply-To: <20190628101131.GA22862@sigill.intra.peff.net>
On Fri, Jun 28, 2019 at 06:11:31AM -0400, Jeff King wrote:
> Subject: [PATCH] check_everything_connected: assume alternate ref tips...
Heh. This subject should just be "check_connected" these days. I wrote
this patch originally many years ago, before 7043c7071c
(check_everything_connected: use a struct with named options,
2016-07-15) gave the function a shorter name.
But the patch has been updated recently to match other updates to the
alternates code. In particular, in the original "rev-list
--alternate-refs" behaved as if all of the refs from the alternate were
mentioned on the command line, and you could use --exclude, etc as if
they were real refs. But we've since simplified the alternates interface
to just get a list of oids, so now it behaves more like
"--indexed-objects" in that it acts as if those oids were mentioned on
the command line.
I think "--alternate-refs" is still the right name, though, since we're
just giving the oids at the ref tips. And I think the included
documentation makes this clear.
-Peff
next prev parent reply other threads:[~2019-06-28 10:19 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-06-28 10:11 [PATCH] check_everything_connected: assume alternate ref tips are valid Jeff King
2019-06-28 10:18 ` Jeff King [this message]
2019-06-28 12:51 ` Derrick Stolee
2019-06-29 7:43 ` Jeff King
2019-07-01 12:25 ` Derrick Stolee
2019-07-01 12:59 ` Jeff King
2019-07-01 13:17 ` Jeff King
2019-07-01 13:17 ` [PATCH 1/2] object-store.h: move for_each_alternate_ref() from transport.h Jeff King
2019-07-01 13:23 ` Derrick Stolee
2019-07-01 13:18 ` [PATCH v2 2/2] check_everything_connected: assume alternate ref tips are valid Jeff King
2019-07-03 9:12 ` SZEDER Gábor
2019-07-03 16:41 ` Jeff King
2019-07-03 16:46 ` Junio C Hamano
2019-07-03 16:50 ` SZEDER Gábor
2019-07-03 17:05 ` Junio C Hamano
2019-07-01 17:02 ` [PATCH] " Taylor Blau
2019-07-02 5:29 ` Jeff King
2019-06-28 16:22 ` Junio C Hamano
2019-06-29 7:55 ` Jeff King
2019-07-01 12:26 ` Derrick Stolee
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190628101858.GA23052@sigill.intra.peff.net \
--to=peff@peff.net \
--cc=git@vger.kernel.org \
--cc=me@ttaylorr.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).