From: Jeff King <peff@peff.net>
To: Junio C Hamano <gitster@pobox.com>
Cc: Matt Turner <mattst88@gmail.com>, Rene Scharfe <l.s.r@web.de>,
git@vger.kernel.org,
David Oberhollenzer <david.oberhollenzer@sigma-star.at>
Subject: Re: [PATCH] archive: Store checksum correctly
Date: Tue, 23 Jul 2019 15:31:19 -0400 [thread overview]
Message-ID: <20190723193119.GA3879@sigill.intra.peff.net> (raw)
In-Reply-To: <xmqqd0i0u253.fsf@gitster-ct.c.googlers.com>
On Tue, Jul 23, 2019 at 09:49:44AM -0700, Junio C Hamano wrote:
> I think a change like this would impact kernel.org folks' tarball
> uploading tool, but that is not a reason not to apply this patch.
That was my thought, too. Distro projects like homebrew rely on
stable hashes of upstream tarballs, and they get cranky when those
tarballs change. Ideally the projects they package would provide
byte-stable tarballs, but many of them rely on on-the-fly tarball
generation by hosting sites like GitHub.
Which isn't to say we should never fix bugs in the tarballs that we
produce, but it's not entirely clear to me that this _is_ a bug, and not
just one tool being overly picky.
-Peff
next prev parent reply other threads:[~2019-07-23 19:31 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-07-23 2:57 [PATCH] archive: Store checksum correctly Matt Turner
2019-07-23 16:49 ` Junio C Hamano
2019-07-23 19:31 ` Jeff King [this message]
2019-07-23 19:38 ` René Scharfe
2019-07-23 20:08 ` René Scharfe
2019-07-23 21:34 ` David Oberhollenzer
2019-07-23 21:21 ` Junio C Hamano
2019-07-24 1:04 ` Jonathan Nieder
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190723193119.GA3879@sigill.intra.peff.net \
--to=peff@peff.net \
--cc=david.oberhollenzer@sigma-star.at \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
--cc=l.s.r@web.de \
--cc=mattst88@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).