From: Jeff King <peff@peff.net>
To: "Raitanen, Adam" <araitane@ciena.com>
Cc: James Knight <james.d.knight@live.com>,
"git@vger.kernel.org" <git@vger.kernel.org>
Subject: Re: [**EXTERNAL**] Re: Possible bug in Makefile when executing curl-config
Date: Tue, 23 Jul 2019 16:16:50 -0400 [thread overview]
Message-ID: <20190723201649.GA4995@sigill.intra.peff.net> (raw)
In-Reply-To: <DM6PR04MB479387667E7EDEF2A27BFCA2D0C70@DM6PR04MB4793.namprd04.prod.outlook.com>
On Tue, Jul 23, 2019 at 07:43:01PM +0000, Raitanen, Adam wrote:
> Yes there is a config.mak.autogen and it does not have an entry for CURL_CONFIG, although it has a correct entry for CURLDIR.
>
> The config.log also shows it checking for curl-config and not finding it then proceeding anyway:
>
> configure:5917: checking for curl-config
> configure:5945: result: no
OK, that makes sense from what I see in configure.ac. The "--with-curl"
flag does not interact at all with the curl-config test, but only sets
CURLDIR.
It seems like we should at least look for $CURLDIR/bin/curl-config in
such a case. But I think the fallback patch I showed earlier would
probably work for you, too (since on your system "curl-config --libs" is
likely just going to show "-lcurl" anyway).
Let's see what James says.
-Peff
prev parent reply other threads:[~2019-07-23 20:16 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-07-22 19:46 Possible bug in Makefile when executing curl-config Raitanen, Adam
2019-07-22 21:12 ` Jeff King
2019-07-23 19:43 ` [**EXTERNAL**] " Raitanen, Adam
2019-07-23 20:16 ` Jeff King [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190723201649.GA4995@sigill.intra.peff.net \
--to=peff@peff.net \
--cc=araitane@ciena.com \
--cc=git@vger.kernel.org \
--cc=james.d.knight@live.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).