From: "SZEDER Gábor" <szeder.dev@gmail.com>
To: git@vger.kernel.org
Cc: Junio C Hamano <gitster@pobox.com>,
Thomas Rast <tr@thomasrast.ch>, Derrick Stolee <stolee@gmail.com>
Subject: Re: [RFC PATCH 4/5] line-log: more responsive, incremental 'git log -L'
Date: Mon, 19 Aug 2019 14:34:31 +0200 [thread overview]
Message-ID: <20190819123431.GT20404@szeder.dev> (raw)
In-Reply-To: <20190818182801.7580-5-szeder.dev@gmail.com>
On Sun, Aug 18, 2019 at 08:28:00PM +0200, SZEDER Gábor wrote:
> The current line-level log implementation performs a preprocessing
> step in prepare_revision_walk(), during which the line_log_filter()
> function filters and rewrites history to keep only commits modifying
> the given line range. This preprocessing affects both responsiveness
> and correctness:
>
> - Git doesn't produce any output during this preprocessing step.
> Checking whether a commit modified the given line range is
> somewhat expensive, so depending on the size of the given revision
> range this preprocessing can result in a significant delay before
> the first commit is shown.
>
> - Limiting the number of displayed commits (e.g. 'git log -3 -L...')
> doesn't limit the amount of work during preprocessing, because
> that limit is applied during history traversal. Alas, by that
> point this expensive preprocessing step has already churned
> through the whole revision range to find all commits modifying the
> revision range, even though only a few of them need to be shown.
s/revision range/line range/
next prev parent reply other threads:[~2019-08-19 12:34 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-08-18 18:27 [RFC PATCH 0/5] line-log: towards a more responsive, incremental 'git log -L' SZEDER Gábor
2019-08-18 18:27 ` [RFC PATCH 1/5] completion: offer '--(no-)patch' among 'git log' options SZEDER Gábor
2019-08-18 18:27 ` [RFC PATCH 2/5] line-log: remove unused fields from 'struct line_log_data' SZEDER Gábor
2019-08-19 11:53 ` Derrick Stolee
2019-08-18 18:27 ` [RFC PATCH 3/5] t4211-line-log: add tests for parent oids SZEDER Gábor
2019-08-18 18:28 ` [RFC PATCH 4/5] line-log: more responsive, incremental 'git log -L' SZEDER Gábor
2019-08-19 12:34 ` SZEDER Gábor [this message]
2019-08-19 12:43 ` Derrick Stolee
2019-08-18 18:28 ` [RFC PATCH 5/5] line-log: try to use generation number-based topo-ordering SZEDER Gábor
2019-08-19 12:00 ` [RFC PATCH 0/5] line-log: towards a more responsive, incremental 'git log -L' Derrick Stolee
2019-08-19 13:03 ` SZEDER Gábor
2019-08-19 14:50 ` Derrick Stolee
2019-08-19 15:02 ` SZEDER Gábor
2019-08-19 16:12 ` Derrick Stolee
2019-08-21 11:07 ` SZEDER Gábor
2020-04-09 12:17 ` Derrick Stolee
2020-04-24 9:02 ` SZEDER Gábor
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190819123431.GT20404@szeder.dev \
--to=szeder.dev@gmail.com \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
--cc=stolee@gmail.com \
--cc=tr@thomasrast.ch \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).