From: Jeff King <peff@peff.net>
To: Taylor Blau <me@ttaylorr.com>
Cc: git@vger.kernel.org, "SZEDER Gábor" <szeder.dev@gmail.com>,
"Ævar Arnfjörð Bjarmason" <avarab@gmail.com>,
"Derrick Stolee" <stolee@gmail.com>
Subject: Re: [PATCH 2/2] commit-graph: turn off save_commit_buffer
Date: Sun, 8 Sep 2019 06:31:19 -0400 [thread overview]
Message-ID: <20190908103118.GD15641@sigill.intra.peff.net> (raw)
In-Reply-To: <20190907185636.GB32028@syl.local>
On Sat, Sep 07, 2019 at 02:56:36PM -0400, Taylor Blau wrote:
> So, the patch here looks obviously correct, and I don't think it needs a
> test or anything like that... besides: what is there to test? :).
There's no functional change, so as long as this has coverage in the
regular suite (and I think it does), there's no point in adding a new
functional test.
However, it may make sense to get some coverage of commit graphs in the
perf suite, so that we could detect regressions there. I think that
would make sense as a separate series, though, not attached to this
particular fix. (It would also be cool if the perf suite could record
peak memory usage, but that would take a fair bit of refactoring).
-Peff
prev parent reply other threads:[~2019-09-08 10:31 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-09-07 4:58 [PATCH 0/2] a few commit-graph improvements Jeff King
2019-09-07 5:01 ` [PATCH 1/2] commit-graph: don't show progress percentages while expanding reachable commits Jeff King
2019-09-07 10:34 ` SZEDER Gábor
2019-09-07 18:54 ` Taylor Blau
2019-09-27 18:54 ` Linus Torvalds
2019-09-07 5:04 ` [PATCH 2/2] commit-graph: turn off save_commit_buffer Jeff King
2019-09-07 18:56 ` Taylor Blau
2019-09-08 10:31 ` Jeff King [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190908103118.GD15641@sigill.intra.peff.net \
--to=peff@peff.net \
--cc=avarab@gmail.com \
--cc=git@vger.kernel.org \
--cc=me@ttaylorr.com \
--cc=stolee@gmail.com \
--cc=szeder.dev@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).