git.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Eric Freese <ericdfreese@gmail.com>
To: git@vger.kernel.org
Cc: Eric Freese <ericdfreese@gmail.com>
Subject: [RFC PATCH 0/1] for-each-ref: do not output empty lines
Date: Mon,  9 Sep 2019 23:17:04 -0600	[thread overview]
Message-ID: <20190910051705.2765-1-ericdfreese@gmail.com> (raw)

Hi,

This is a follow-up patch based on conversation from the thread: "[RFC
PATCH 1/1] for-each-ref: add '--no-symbolic' option"

I had proposed a `--no-symbolic` option to git-for-each-ref that would
filter out symbolic refs from the output. It was discovered that the
behavior was already possible using an `%(if)` atom, but with the small
caveat that empty lines would be output for each non-symbolic ref.

This patch changes the output behavior of git-for-each-ref such that it
only prints lines for refs for which the format string expands to a
non-empty string.

If this is deemed to be too disruptive of a change, a new command option
could be added to opt in to the new behavior.

Cheers

Eric Freese (1):
  for-each-ref: do not output empty lines

 ref-filter.c            | 3 ++-
 t/t6300-for-each-ref.sh | 4 ++--
 2 files changed, 4 insertions(+), 3 deletions(-)

-- 
2.23.0


             reply	other threads:[~2019-09-10  5:16 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-09-10  5:17 Eric Freese [this message]
2019-09-10  5:17 ` [RFC PATCH 1/1] for-each-ref: do not output empty lines Eric Freese
2019-09-10  6:02   ` Junio C Hamano
2019-09-10  6:14     ` Junio C Hamano
2019-09-10 16:35     ` Jeff King

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20190910051705.2765-1-ericdfreese@gmail.com \
    --to=ericdfreese@gmail.com \
    --cc=git@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).