From: "SZEDER Gábor" <szeder.dev@gmail.com>
To: Junio C Hamano <gitster@pobox.com>
Cc: git@vger.kernel.org
Subject: Re: [PATCH] travis-ci: ignore already tested trees in debug mode
Date: Fri, 20 Sep 2019 20:17:32 +0200 [thread overview]
Message-ID: <20190920181732.GC26402@szeder.dev> (raw)
In-Reply-To: <xmqqftkqvo8r.fsf@gitster-ct.c.googlers.com>
On Fri, Sep 20, 2019 at 11:03:48AM -0700, Junio C Hamano wrote:
> SZEDER Gábor <szeder.dev@gmail.com> writes:
>
> > skip_good_tree () {
> > + if test "$TRAVIS_DEBUG_MODE" = true
> > + then
> > + return
> > + fi
>
> I think you convinced readers why it is a good idea to avoid
> skipping an already tested tree, and technically the title of this
> commit is not incorrect per-se. You are teaching to ignore
> "already-tested-ness" from a part of the logic).
Hrm, that's subtle, but you are right.
> But in the larger picture, I would expect that readers would more
> immediately grasp what it is about if it were titled "do not skip
> versions that have already tested good in debug mode"
Will try to come up with a better subject line, but I don't have any
usable ideas at the moment.
> or something
> like that (IOW, we do not want to ignore such trees, we want to test
> them again).
>
next prev parent reply other threads:[~2019-09-20 18:17 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-09-19 17:35 [PATCH] travis-ci: ignore already tested trees in debug mode SZEDER Gábor
2019-09-20 18:03 ` Junio C Hamano
2019-09-20 18:17 ` SZEDER Gábor [this message]
2019-09-20 18:28 ` Junio C Hamano
2019-09-20 21:56 ` SZEDER Gábor
2019-09-21 7:40 ` [PATCH v2] travis-ci: do not skip successfully " SZEDER Gábor
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190920181732.GC26402@szeder.dev \
--to=szeder.dev@gmail.com \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).