From: "SZEDER Gábor" <szeder.dev@gmail.com>
To: "brian m. carlson" <sandals@crustytoothpaste.net>,
Junio C Hamano <gitster@pobox.com>,
git@vger.kernel.org
Subject: Re: [PATCH] name-rev: avoid cutoff timestamp underflow
Date: Mon, 23 Sep 2019 10:39:49 +0200 [thread overview]
Message-ID: <20190923083949.GE10866@szeder.dev> (raw)
In-Reply-To: <20190923012838.3hzai6ho7vjjhkpb@camp.crustytoothpaste.net>
On Mon, Sep 23, 2019 at 01:42:30AM +0000, brian m. carlson wrote:
> On 2019-09-22 at 18:01:43, SZEDER Gábor wrote:
> > diff --git a/builtin/name-rev.c b/builtin/name-rev.c
> > index c785fe16ba..a4d8d312ab 100644
> > --- a/builtin/name-rev.c
> > +++ b/builtin/name-rev.c
> > @@ -9,7 +9,11 @@
> > #include "sha1-lookup.h"
> > #include "commit-slab.h"
> >
> > -#define CUTOFF_DATE_SLOP 86400 /* one day */
> > +/*
> > + * One day. See the 'name a rev close to epoch' test in t6120 when
>
> This piece of code says "close to"…
>
> > +test_expect_success 'name-rev a rev shortly after epoch' '
>
> …but this says "shortly after."
Thanks. I did a last minute 'close to' -> 'shortly after' edit, but
apparently not everywhere.
> Overall, I think the idea is definitely sane, though.
> --
> brian m. carlson: Houston, Texas, US
> OpenPGP: https://keybase.io/bk2204
next prev parent reply other threads:[~2019-09-23 8:39 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-09-22 18:01 [PATCH] name-rev: avoid cutoff timestamp underflow SZEDER Gábor
2019-09-22 18:57 ` Phillip Wood
2019-09-22 19:53 ` SZEDER Gábor
2019-09-22 21:01 ` Johannes Sixt
2019-09-23 8:37 ` SZEDER Gábor
2019-09-23 9:30 ` Phillip Wood
2019-09-23 19:16 ` Johannes Sixt
2019-09-24 7:21 ` SZEDER Gábor
2019-09-23 1:42 ` brian m. carlson
2019-09-23 8:39 ` SZEDER Gábor [this message]
2019-09-24 7:32 ` SZEDER Gábor
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190923083949.GE10866@szeder.dev \
--to=szeder.dev@gmail.com \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
--cc=sandals@crustytoothpaste.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).