From: Jeff King <peff@peff.net>
To: Sebastiaan Dammann <triadsebas@gmail.com>
Cc: "SZEDER Gábor" <szeder.dev@gmail.com>, git@vger.kernel.org
Subject: Re: git name-rev looks at refs/notes, refs/svn/map: stack overflow
Date: Sun, 10 Nov 2019 23:21:49 -0500 [thread overview]
Message-ID: <20191111042149.GE6379@sigill.intra.peff.net> (raw)
In-Reply-To: <CAE7Eq9jJzftkP9JWFpstS96SiCd+jO_adSQ-HruyYYNi3gWe7w@mail.gmail.com>
On Sat, Nov 09, 2019 at 12:31:31PM +0100, Sebastiaan Dammann wrote:
> The destructive workaround at the moment is to delete the refs, then
> run an aggressive gc:
> git update-ref -d refs/notes/commits
> git update-ref -d refs/svn/map
> git gc --prune=all --aggressive
If the issue is just traversing from those refs, you shouldn't need to
do a "gc". In fact, you should be able to use the "--refs" option to
name-rev to avoid them without deleting them.
All of that's obviously a workaround, though. The real issue is the
stack exhaustion.
> I hope to hear your view on this. Is this an (confirmed) issue with
> git? Are there beside the workaround I mentioned, any other
> workarounds?
Yes, this is well known. It's covered in the test suite (unfortunately
still failing, of course) since 31625b34c0 (t6120: test describe and
name-rev with deep repos, 2017-09-07).
There was a proposed fix recently in:
https://public-inbox.org/git/20190919214712.7348-1-szeder.dev@gmail.com/
but it doesn't seem to have been picked up. I'm not sure what the
current status is.
-Peff
next prev parent reply other threads:[~2019-11-11 4:21 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-11-09 11:31 git name-rev looks at refs/notes, refs/svn/map: stack overflow Sebastiaan Dammann
2019-11-11 4:21 ` Jeff King [this message]
2019-11-11 14:09 ` SZEDER Gábor
2019-11-12 18:33 ` Sebastiaan Dammann
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20191111042149.GE6379@sigill.intra.peff.net \
--to=peff@peff.net \
--cc=git@vger.kernel.org \
--cc=szeder.dev@gmail.com \
--cc=triadsebas@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).