From: Jeff King <peff@peff.net>
To: Derrick Stolee via GitGitGadget <gitgitgadget@gmail.com>
Cc: git@vger.kernel.org, bturner@atlassian.com,
Derrick Stolee <dstolee@microsoft.com>,
Junio C Hamano <gitster@pobox.com>
Subject: Re: [PATCH 1/1] test-tool: use 'read-graph' helper
Date: Wed, 13 Nov 2019 00:31:51 -0500 [thread overview]
Message-ID: <20191113053151.GC3547@sigill.intra.peff.net> (raw)
In-Reply-To: <bdbc7b71884cba192c67c2bc26db5b9b3a040043.1573577900.git.gitgitgadget@gmail.com>
On Tue, Nov 12, 2019 at 04:58:20PM +0000, Derrick Stolee via GitGitGadget wrote:
> From: Derrick Stolee <dstolee@microsoft.com>
>
> The 'git commit-graph read' subcommand is used in test scripts to check
> that the commit-graph contents match the expected data. Mostly, this
> helps check the header information and the list of chunks. Users do not
> need this information, so move the functionality to a test helper.
This looks good to me.
> t/helper/test-read-graph.c | 53 +++++++++++++++++++++++
I wondered if we might want a commit-graph test-tool with sub-commands.
But it probably doesn't matter. This would be the only thing in it. And
there's less need these days to keep the number of tools down, since
they're all linked into the same binary. And we can always change it
later, since it's not a public interface.
So this is the simplest thing, which is probably best for now.
-Peff
prev parent reply other threads:[~2019-11-13 5:31 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-11-12 16:58 [PATCH 0/1] Move 'git commit-graph read' subcommand to test helper Derrick Stolee via GitGitGadget
2019-11-12 16:58 ` [PATCH 1/1] test-tool: use 'read-graph' helper Derrick Stolee via GitGitGadget
2019-11-13 5:31 ` Jeff King [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20191113053151.GC3547@sigill.intra.peff.net \
--to=peff@peff.net \
--cc=bturner@atlassian.com \
--cc=dstolee@microsoft.com \
--cc=git@vger.kernel.org \
--cc=gitgitgadget@gmail.com \
--cc=gitster@pobox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).