From: Denton Liu <liu.denton@gmail.com>
To: Junio C Hamano <gitster@pobox.com>
Cc: "Force.Charlie" <force@forcemz.net>, git <git@vger.kernel.org>
Subject: Re: Protocol v2: The wrong --shallow-since time format causes git to wait indefinitely
Date: Tue, 19 Nov 2019 15:36:45 -0800 [thread overview]
Message-ID: <20191119233645.GA99848@generichostname> (raw)
In-Reply-To: <xmqqpnhwbfx7.fsf@gitster-ct.c.googlers.com>
Hi Junio,
On Wed, Nov 13, 2019 at 12:42:28PM +0900, Junio C Hamano wrote:
> "Force.Charlie" <force@forcemz.net> writes:
>
> > # time format wrong
> > git -c protocol.version=2 clone https://github.com/git/git.git --shallow-since=20151012
>
> That's the valid/right way to specify the timestamp that is
> 20,151,012 seconds after the epoch (i.e. 1970-01-01), isn't it?
I don't think so. When we run the same thing under protocol v1, we get
the following:
$ git -c protocol.version=1 clone https://github.com/git/git.git --shallow-since=20151012
Cloning into 'git'...
fatal: the remote end hung up unexpectedly
even though the following does work:
$ git -c protocol.version=1 clone https://github.com/git/git.git --shallow-since=2015-10-12
Cloning into 'git'...
remote: Enumerating objects: 93982, done.
...
which suggests to me that the non-dashed form is invalid.
Thanks,
Denton
next prev parent reply other threads:[~2019-11-19 23:36 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-11-13 1:00 Protocol v2: The wrong --shallow-since time format causes git to wait indefinitely =?gb18030?B?Rm9yY2UuQ2hhcmxpZQ==?=
2019-11-13 3:42 ` Junio C Hamano
2019-11-19 23:36 ` Denton Liu [this message]
2019-11-19 23:46 ` Denton Liu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20191119233645.GA99848@generichostname \
--to=liu.denton@gmail.com \
--cc=force@forcemz.net \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).