git.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Denton Liu <liu.denton@gmail.com>
To: Craig H Maynard <chmaynard@me.com>
Cc: git@vger.kernel.org
Subject: Re: Git CLI
Date: Fri, 22 Nov 2019 10:04:33 -0800	[thread overview]
Message-ID: <20191122180433.GA57478@generichostname> (raw)
In-Reply-To: <3AD06998-1729-46C2-8B60-BD405C365656@me.com>

Hi Craig,

Thanks for the report.

On Fri, Nov 22, 2019 at 08:12:48AM -0500, Craig H Maynard wrote:
> Just noticed this:
> 
> $ git pull
> Already up to date.
> $ git push
> Everything up-to-date
> 
> The two messages covey the same information but use different punctuation and hyphenation. While not terribly important, this quirky inconsistency doesn't inspire confidence.

Unfortunately, this has been caught before but remains for legacy
reasons.

According to 7560f547e6 (treewide: correct several "up-to-date" to "up
to date", 2017-08-23), it explicitly mentions in the commit message,
"Don't change plumbing (specifically send-pack.c, but transport.c (git
push) also has the same string)."

So as a result, we can't change the `git push` string to match. I don't
think it would make too much sense to change the `git pull` string to
match either since that would intentionally introduce the "up-to-date"
error that the above commit fixed.

Thanks,

Denton

> 
> My environment:
> 
> git version 2.24.0
> hub version 2.13.0
> 
> --
> Craig H Maynard
> Rhode Island, USA
> 

      reply	other threads:[~2019-11-22 18:04 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-11-22 13:12 Git CLI Craig H Maynard
2019-11-22 18:04 ` Denton Liu [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20191122180433.GA57478@generichostname \
    --to=liu.denton@gmail.com \
    --cc=chmaynard@me.com \
    --cc=git@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).