git.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
* Git CLI
@ 2019-11-22 13:12 Craig H Maynard
  2019-11-22 18:04 ` Denton Liu
  0 siblings, 1 reply; 2+ messages in thread
From: Craig H Maynard @ 2019-11-22 13:12 UTC (permalink / raw)
  To: git

Just noticed this:

$ git pull
Already up to date.
$ git push
Everything up-to-date

The two messages covey the same information but use different punctuation and hyphenation. While not terribly important, this quirky inconsistency doesn't inspire confidence.

My environment:

git version 2.24.0
hub version 2.13.0

--
Craig H Maynard
Rhode Island, USA


^ permalink raw reply	[flat|nested] 2+ messages in thread

* Re: Git CLI
  2019-11-22 13:12 Git CLI Craig H Maynard
@ 2019-11-22 18:04 ` Denton Liu
  0 siblings, 0 replies; 2+ messages in thread
From: Denton Liu @ 2019-11-22 18:04 UTC (permalink / raw)
  To: Craig H Maynard; +Cc: git

Hi Craig,

Thanks for the report.

On Fri, Nov 22, 2019 at 08:12:48AM -0500, Craig H Maynard wrote:
> Just noticed this:
> 
> $ git pull
> Already up to date.
> $ git push
> Everything up-to-date
> 
> The two messages covey the same information but use different punctuation and hyphenation. While not terribly important, this quirky inconsistency doesn't inspire confidence.

Unfortunately, this has been caught before but remains for legacy
reasons.

According to 7560f547e6 (treewide: correct several "up-to-date" to "up
to date", 2017-08-23), it explicitly mentions in the commit message,
"Don't change plumbing (specifically send-pack.c, but transport.c (git
push) also has the same string)."

So as a result, we can't change the `git push` string to match. I don't
think it would make too much sense to change the `git pull` string to
match either since that would intentionally introduce the "up-to-date"
error that the above commit fixed.

Thanks,

Denton

> 
> My environment:
> 
> git version 2.24.0
> hub version 2.13.0
> 
> --
> Craig H Maynard
> Rhode Island, USA
> 

^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2019-11-22 18:04 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2019-11-22 13:12 Git CLI Craig H Maynard
2019-11-22 18:04 ` Denton Liu

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).