From: Jeff King <peff@peff.net>
To: Junio C Hamano <gitster@pobox.com>
Cc: Hariom Verma via GitGitGadget <gitgitgadget@gmail.com>,
git@vger.kernel.org, Hariom Verma <hariom18599@gmail.com>
Subject: Re: [PATCH 1/1] git-compat-util.h: drop the `PRIuMAX` definition
Date: Mon, 25 Nov 2019 04:34:00 -0500 [thread overview]
Message-ID: <20191125093400.GA25851@sigill.intra.peff.net> (raw)
In-Reply-To: <xmqqv9r8y8qe.fsf@gitster-ct.c.googlers.com>
On Mon, Nov 25, 2019 at 11:45:29AM +0900, Junio C Hamano wrote:
> Junio C Hamano <gitster@pobox.com> writes:
>
> >> Can we likewise ditch the fallback definition for SCNuMAX? And PRIu32,
> >> etc? It seems likely any platform would either have all of them or none.
> >
> > I guess that's also a C99-ism that we can use?
> >
> > Thanks, both.
>
> Here is what I have locally for now.
Yes, that looks good to me (and yes, those other format macros are in
C99, too).
-Peff
prev parent reply other threads:[~2019-11-25 9:34 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-11-24 13:09 [PATCH 0/1] git-compat-util.h: drop the PRIuMAX definition Hariom Verma via GitGitGadget
2019-11-24 13:09 ` [PATCH 1/1] git-compat-util.h: drop the `PRIuMAX` definition Hariom Verma via GitGitGadget
2019-11-24 17:06 ` Jeff King
2019-11-24 17:40 ` Carlo Arenas
2019-11-24 20:15 ` Carlo Arenas
2019-11-25 2:24 ` Junio C Hamano
2019-11-25 2:45 ` Junio C Hamano
2019-11-25 9:34 ` Jeff King [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20191125093400.GA25851@sigill.intra.peff.net \
--to=peff@peff.net \
--cc=git@vger.kernel.org \
--cc=gitgitgadget@gmail.com \
--cc=gitster@pobox.com \
--cc=hariom18599@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).