From: Jeff King <peff@peff.net>
To: "SZEDER Gábor" <szeder.dev@gmail.com>
Cc: Junio C Hamano <gitster@pobox.com>, git@vger.kernel.org
Subject: Re: [PATCH] test-lib-functions: suppress a 'git rev-parse' error in 'test_commit_bulk'
Date: Mon, 25 Nov 2019 08:19:51 -0500 [thread overview]
Message-ID: <20191125131951.GA494@sigill.intra.peff.net> (raw)
In-Reply-To: <20191125125907.28967-1-szeder.dev@gmail.com>
On Mon, Nov 25, 2019 at 01:59:07PM +0100, SZEDER Gábor wrote:
> When 'test_commit_bulk' is invoked in an empty test repository, it
> prints a "fatal: Needed a single revision" error, but still does what
> it's supposed to do. A test helper function displaying a fatal error
> and still succeeding is always suspect to be buggy, but luckily that's
> not the case here: that error comes from a 'git rev-parse --verify
> HEAD' command invoked in a condition, which doesn't have anything to
> verify in an empty repository.
>
> Use the '--quiet' option to suppress that error message.
Yep, makes perfect sense. Thanks.
-Peff
prev parent reply other threads:[~2019-11-25 13:19 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-11-25 12:59 [PATCH] test-lib-functions: suppress a 'git rev-parse' error in 'test_commit_bulk' SZEDER Gábor
2019-11-25 13:19 ` Jeff King [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20191125131951.GA494@sigill.intra.peff.net \
--to=peff@peff.net \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
--cc=szeder.dev@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).