* No tab completion for git version?
@ 2019-11-22 10:19 ryenus
2019-11-27 17:42 ` Jeff King
0 siblings, 1 reply; 2+ messages in thread
From: ryenus @ 2019-11-22 10:19 UTC (permalink / raw)
To: Git mailing list
Tab completion works for `git --version`, but not `git version`.
Of course, it would work with a custom executable script git-version on PATH.
Interestingly, it works even if the git-version script is an empty file.
^ permalink raw reply [flat|nested] 2+ messages in thread
* Re: No tab completion for git version?
2019-11-22 10:19 No tab completion for git version? ryenus
@ 2019-11-27 17:42 ` Jeff King
0 siblings, 0 replies; 2+ messages in thread
From: Jeff King @ 2019-11-27 17:42 UTC (permalink / raw)
To: ryenus; +Cc: Git mailing list
On Fri, Nov 22, 2019 at 06:19:27PM +0800, ryenus wrote:
> Tab completion works for `git --version`, but not `git version`.
> Of course, it would work with a custom executable script git-version on PATH.
>
> Interestingly, it works even if the git-version script is an empty file.
It's because git-version isn't mentioned in "git help -a", from which we
generate the completion list. That comes from command-list.h, which in
turn is generated from command-list.txt, which doesn't mention
git-version as a command. And we can't add it there until it has a
manpage (since we pull the oneline description from the synopsis).
It might not be a bad thing to have a manpage. For example, the
--build-options is undocumented.
cmd_version() is also weirdly in help.c, not builtin/help.c, which might
be worth fixing.
-Peff
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2019-11-27 17:42 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2019-11-22 10:19 No tab completion for git version? ryenus
2019-11-27 17:42 ` Jeff King
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).