From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-0.8 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id E356EC43603 for ; Mon, 9 Dec 2019 07:14:55 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id BF44220726 for ; Mon, 9 Dec 2019 07:14:55 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726957AbfLIHOy (ORCPT ); Mon, 9 Dec 2019 02:14:54 -0500 Received: from cloud.peff.net ([104.130.231.41]:41802 "HELO cloud.peff.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with SMTP id S1726014AbfLIHOy (ORCPT ); Mon, 9 Dec 2019 02:14:54 -0500 Received: (qmail 18476 invoked by uid 109); 9 Dec 2019 07:14:54 -0000 Received: from Unknown (HELO peff.net) (10.0.1.2) by cloud.peff.net (qpsmtpd/0.94) with SMTP; Mon, 09 Dec 2019 07:14:54 +0000 Authentication-Results: cloud.peff.net; auth=none Received: (qmail 18496 invoked by uid 111); 9 Dec 2019 07:19:11 -0000 Received: from coredump.intra.peff.net (HELO sigill.intra.peff.net) (10.0.0.2) by peff.net (qpsmtpd/0.94) with (TLS_AES_256_GCM_SHA384 encrypted) ESMTPS; Mon, 09 Dec 2019 02:19:11 -0500 Authentication-Results: peff.net; auth=none Date: Mon, 9 Dec 2019 02:14:53 -0500 From: Jeff King To: Christian Couder Cc: git@vger.kernel.org, Junio C Hamano , Christian Couder , Ramsay Jones , Jonathan Tan Subject: Re: [PATCH v3 8/9] builtin/pack-objects: introduce obj_is_packed() Message-ID: <20191209071453.GH40570@coredump.intra.peff.net> References: <20191115141541.11149-1-chriscool@tuxfamily.org> <20191115141541.11149-9-chriscool@tuxfamily.org> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: <20191115141541.11149-9-chriscool@tuxfamily.org> Sender: git-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: git@vger.kernel.org On Fri, Nov 15, 2019 at 03:15:40PM +0100, Christian Couder wrote: > From: Jeff King > > Let's refactor the way we check if an object is packed by > introducing obj_is_packed(). This function is now a simple > wrapper around packlist_find(), but it will evolve in a > following commit. Yep, this is a good refactor. -Peff