From: Arnaud Bertrand <xda@abalgo.com>
To: arnaud.bertrand@abalgo.com
Cc: git@vger.kernel.org, gitster@pobox.com, xda@abalgo.com
Subject: [RFC PATCH 1/2 v2] Add branchname in commit header
Date: Mon, 30 Dec 2019 17:32:55 +0100 [thread overview]
Message-ID: <20191230163256.14749-2-xda@abalgo.com> (raw)
In-Reply-To: <20191230163256.14749-1-xda@abalgo.com>
Add the branchname in the commit header before the commit message
the following line is added:
branch <branchname>
where <branchname> comes from the function resolve_ref_unsafe("HEAD",...)
without the prefix refs/heads/
A placeholder is added to the pretty format "%Xb" to print the branch information,
X if for "extra-header" and can be use in the future for new features
b is of course for "branch"
the %Xb returns an empty string when branchname information is not found
---
Documentation/pretty-formats.txt | 1 +
commit.c | 11 +++++++++++
pretty.c | 15 +++++++++++++++
3 files changed, 27 insertions(+)
diff --git a/Documentation/pretty-formats.txt b/Documentation/pretty-formats.txt
index 1a7212ce5a..bd52908f53 100644
--- a/Documentation/pretty-formats.txt
+++ b/Documentation/pretty-formats.txt
@@ -241,6 +241,7 @@ endif::git-rev-list[]
'%gE':: reflog identity email (respecting .mailmap, see
linkgit:git-shortlog[1] or linkgit:git-blame[1])
'%gs':: reflog subject
+'%Xb':: branchname in which commit was done
'%(trailers[:options])':: display the trailers of the body as
interpreted by
linkgit:git-interpret-trailers[1]. The
diff --git a/commit.c b/commit.c
index 434ec030d6..f64a0698be 100644
--- a/commit.c
+++ b/commit.c
@@ -1425,6 +1425,9 @@ int commit_tree_extended(const char *msg, size_t msg_len,
int result;
int encoding_is_utf8;
struct strbuf buffer;
+ const char *branch = "Unknown";
+ int flags;
+ const char *lbranch =resolve_ref_unsafe("HEAD",0,NULL,&flags);
assert_oid_type(tree, OBJ_TREE);
@@ -1453,6 +1456,14 @@ int commit_tree_extended(const char *msg, size_t msg_len,
author = git_author_info(IDENT_STRICT);
strbuf_addf(&buffer, "author %s\n", author);
strbuf_addf(&buffer, "committer %s\n", git_committer_info(IDENT_STRICT));
+ if (lbranch) {
+ skip_prefix(lbranch,"refs/heads/",&branch);
+ strbuf_addf(&buffer, "branch %s\n", branch);
+ }
+ else {
+ strbuf_addf(&buffer, "branch Unknown\n");
+ }
+
if (!encoding_is_utf8)
strbuf_addf(&buffer, "encoding %s\n", git_commit_encoding);
diff --git a/pretty.c b/pretty.c
index 305e903192..5961c39398 100644
--- a/pretty.c
+++ b/pretty.c
@@ -804,6 +804,7 @@ struct format_commit_context {
/* The following ones are relative to the result struct strbuf. */
size_t wrap_start;
+ char *branch;
};
static void parse_commit_header(struct format_commit_context *context)
@@ -1367,6 +1368,20 @@ static size_t format_commit_one(struct strbuf *sb, /* in UTF-8 */
return 1;
}
+
+ /* Now add extra header info */
+ if (placeholder[0] == 'X') {
+ switch (placeholder[1]) {
+ case 'b': /* branch ... */
+ c->branch = get_header(msg,"branch");
+ if (c->branch)
+ strbuf_addstr(sb, c->branch);
+ free(c->branch);
+ return 2;
+ }
+ }
+
+
/* Now we need to parse the commit message. */
if (!c->commit_message_parsed)
parse_commit_message(c);
--
2.25.0.rc0.7.g17b02bf28a
next prev parent reply other threads:[~2019-12-30 16:33 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-12-29 22:26 [RFC PATCH 0/1] *** Add branchname in commit header *** Arnaud Bertrand
2019-12-29 22:26 ` [RFC PATCH 1/1] Add branchname in commit header Arnaud Bertrand
2019-12-30 2:32 ` [RFC PATCH 0/1] *** Add branchname in commit header *** brian m. carlson
2019-12-30 10:33 ` Arnaud Bertrand
2019-12-30 16:32 ` [RFC PATCH 0/2 v2] *** Add branchname in commit when core.branchnameincommit is set *** Arnaud Bertrand
2019-12-30 16:32 ` Arnaud Bertrand [this message]
2019-12-30 16:32 ` [RFC PATCH 2/2 v2] Add the configuration parameter core.branchnameincommit Arnaud Bertrand
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20191230163256.14749-2-xda@abalgo.com \
--to=xda@abalgo.com \
--cc=arnaud.bertrand@abalgo.com \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).