git.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Jonathan Nieder <jrnieder@gmail.com>
To: "Marc-André Lureau" <marcandre.lureau@redhat.com>
Cc: git@vger.kernel.org
Subject: Re: [PATCH] RFC: commit: add a commit.all-ignore-submodules config option
Date: Mon, 6 Jan 2020 16:05:51 -0800	[thread overview]
Message-ID: <20200107000551.GE92456@google.com> (raw)
In-Reply-To: <CAMxuvayT8FtovVnWU4bjQCP26drN37yuPG2+G2jAUsm0Ns_AYA@mail.gmail.com>

Marc-André Lureau wrote:
> On Sat, Jan 4, 2020 at 4:45 AM Jonathan Nieder <jrnieder@gmail.com> wrote:
>> Marc-André Lureau wrote:

>>> One of my most frequent mistake is to commit undesired submodules
>>> changes when doing "commit -a", and I have seen a number of people doing
>>> the same mistake in various projects. I wish there would be a config to
>>> change this default behaviour.
>>
>> Can you say more about the overall workflow this is part of?  What
>> causes the submodules to change state in the first place here?
>
> The most common case is, I guess, when you work on different branches
> that have different (compatible) versions of the submodules.

Ah!  This is because "git checkout" defaults to --no-recurse-submodules,
which is a terrible default.

Does "git config submodule.recurse true" help?  If so, we can look
into which it would take to flip that default.

Thanks,
Jonathan

  reply	other threads:[~2020-01-07  0:05 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-01-03 12:06 [PATCH] RFC: commit: add a commit.all-ignore-submodules config option marcandre.lureau
2020-01-04  0:45 ` Jonathan Nieder
2020-01-04 17:24   ` Marc-André Lureau
2020-01-07  0:05     ` Jonathan Nieder [this message]
2020-01-07  5:15       ` Marc-André Lureau

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20200107000551.GE92456@google.com \
    --to=jrnieder@gmail.com \
    --cc=git@vger.kernel.org \
    --cc=marcandre.lureau@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).