From: Jeff King <peff@peff.net>
To: Johannes Schindelin <Johannes.Schindelin@gmx.de>
Cc: Mike McGranahan <mike@mcgwiz.com>, git@vger.kernel.org
Subject: Re: Patch text in git-add patch mode lacks whitespace highlighting
Date: Mon, 3 Feb 2020 03:54:56 -0500 [thread overview]
Message-ID: <20200203085456.GD2164@coredump.intra.peff.net> (raw)
In-Reply-To: <nycvar.QRO.7.76.6.2002012205520.46@tvgsbejvaqbjf.bet>
On Sat, Feb 01, 2020 at 10:06:43PM +0100, Johannes Schindelin wrote:
> > > If my reading is correct, and we want `git diff-files --color` to respect
> > > the `diff.wsErrorHighlight` setting, then this patch fixes that:
> > > [...]
> > > The bigger question is whether other core developers agree with this? And
> > > what other `diff.*` settings should be respected by `git diff-files` (and
> > > of course, `git diff-index`)?
> >
> > I think you can take my posting of an identical patch elsewhere in the
> > thread as a "yes". :)
>
> Thank you ;-)
>
> That answer only applies to the first question, though. The second
> question, whether other `diff.*` settings would like to enjoy the same
> treatment, is still open for debate...
I hoped you would read the other part of the thread where I mused on
that same question. :)
The short of my answer is that I think the color-moved stuff might be a
candidate, but it's sufficiently different that I think it should be
decided on as a separate patch.
-Peff
next prev parent reply other threads:[~2020-02-03 8:54 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-01-30 21:53 Patch text in git-add patch mode lacks whitespace highlighting Mike McGranahan
2020-01-31 9:19 ` Jeff King
2020-01-31 9:57 ` [PATCH] diff: move diff.wsErrorHighlight to "basic" config Jeff King
2020-02-01 0:48 ` Patch text in git-add patch mode lacks whitespace highlighting Mike McGranahan
2020-01-31 12:37 ` Johannes Schindelin
2020-02-01 0:49 ` Mike McGranahan
2020-02-01 11:02 ` Jeff King
2020-02-01 21:06 ` Johannes Schindelin
2020-02-03 8:54 ` Jeff King [this message]
2020-02-03 12:37 ` Johannes Schindelin
2020-02-03 14:51 ` Jeff King
2020-02-04 18:29 ` Junio C Hamano
2020-02-04 19:57 ` Jeff King
2020-02-04 19:04 ` Johannes Schindelin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200203085456.GD2164@coredump.intra.peff.net \
--to=peff@peff.net \
--cc=Johannes.Schindelin@gmx.de \
--cc=git@vger.kernel.org \
--cc=mike@mcgwiz.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).