From: Taylor Blau <me@ttaylorr.com>
To: "SZEDER Gábor" <szeder.dev@gmail.com>
Cc: Taylor Blau <me@ttaylorr.com>, Junio C Hamano <gitster@pobox.com>,
git@vger.kernel.org, martin.agren@gmail.com
Subject: Re: What's cooking in git.git (Feb 2020, #01; Wed, 5)
Date: Thu, 6 Feb 2020 09:48:37 -0800 [thread overview]
Message-ID: <20200206174837.GA55561@syl.local> (raw)
In-Reply-To: <20200206085747.GA17654@szeder.dev>
On Thu, Feb 06, 2020 at 09:57:48AM +0100, SZEDER Gábor wrote:
> On Wed, Feb 05, 2020 at 06:51:30PM -0800, Taylor Blau wrote:
> > > * tb/commit-graph-split-merge (2020-02-05) 3 commits
> > > - builtin/commit-graph.c: support '--input=none'
> > > - builtin/commit-graph.c: introduce '--input=<source>'
> > > - builtin/commit-graph.c: support '--split[=<strategy>]'
> > > (this branch uses tb/commit-graph-object-dir.)
> > >
> > > The code to write out the commit-graph has been taught a few
> > > options to control if the resulting graph chains should be merged
> > > or a single new incremental graph is created.
> > >
> > > Will merge to 'next'?
> >
> > I think that this is ready. Martin Ågren and I discussed a little bit
> > about the rationale behind why the new options were chosen over
> > alternatives, but I think we reached consensus (at least, the thread has
> > been quiet for a few days after sending 'v2').
> >
> > So, if you're asking whether or not this is ready to merge to 'next',
> > I'd say that it is, but I'd like to hear from Martin's thoughts, too.
> > (For what it's worth, we're *also* running this at GitHub, and without
> > issue).
>
> Please don't rush it, those '--input=<source>' options need more
> consideration.
Of course, and I'm happy to discuss more, if that's what others discuss.
I thought that things had settled since the thread quieted down after
sending 'v2'. But, if there's more to discuss, certainly we should do
that before queuing this up.
Let's wait a little while longer and see what happens there before
queuing this topic.
Thanks,
Taylor
next prev parent reply other threads:[~2020-02-06 17:48 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-02-05 23:31 What's cooking in git.git (Feb 2020, #01; Wed, 5) Junio C Hamano
2020-02-06 1:32 ` Elijah Newren
2020-02-06 21:05 ` Phillip Wood
2020-02-06 2:51 ` Taylor Blau
2020-02-06 8:57 ` SZEDER Gábor
2020-02-06 17:48 ` Taylor Blau [this message]
2020-02-06 19:58 ` Martin Ågren
2020-02-10 19:56 ` Taylor Blau
2020-02-06 20:56 ` Martin Ågren
2020-02-07 6:42 ` Christian Couder
2020-02-07 12:45 ` Jeff King
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200206174837.GA55561@syl.local \
--to=me@ttaylorr.com \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
--cc=martin.agren@gmail.com \
--cc=szeder.dev@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).