From: Danh Doan <congdanhqx@gmail.com>
To: Glax <glax@dragon.best>
Cc: git@vger.kernel.org
Subject: Re: gitk crashes if the diff contains certain unicode characters
Date: Sun, 19 Apr 2020 21:30:08 +0700 [thread overview]
Message-ID: <20200419143008.GD28207@danh.dev> (raw)
In-Reply-To: <edace460-d252-2742-7576-e7601b6e959c@dragon.best>
On 2020-04-19 14:15:06+0200, Glax <glax@dragon.best> wrote:
> Looks like certain characters cause gitk to crash when it tries to
> render a diff.
>
>
> How to repro:
>
> git init
> echo foo >foo
> git add foo
> git commit -m foo
> # The following assumes bash builtin echo
> echo -e '\u2754' >foo
> gitk
>
> Now `foo` should contain the character U+2754 encoded as utf-8.
>
> If on gitk you click on "Local uncommitted changes", it'll crash with
> the following message:
>
> X Error of failed request: BadLength (poly request too large or
> internal Xlib length error)
> Major opcode of failed request: 139 (RENDER)
> Minor opcode of failed request: 20 (RenderAddGlyphs)
> Serial number of failed request: 4220
> Current serial number in output stream: 4247
U+2754 is *WHITE* QUESTION MARK ORNAMENT
The error message is very familiar to me.
I /think/ it's a bug in libXft, it can't handle colored emoji, yet.
There're similar issue reported to Google Noto Emoji font:
https://github.com/googlefonts/noto-emoji/issues/183
--
Danh
prev parent reply other threads:[~2020-04-19 14:31 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-04-19 12:15 gitk crashes if the diff contains certain unicode characters Glax
2020-04-19 13:02 ` Andreas Schwab
2020-04-19 14:30 ` Danh Doan [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200419143008.GD28207@danh.dev \
--to=congdanhqx@gmail.com \
--cc=git@vger.kernel.org \
--cc=glax@dragon.best \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).