* minor patch required to compile git 2.26.1 on Oracle Solaris 10 with Oracle Studio
@ 2020-04-19 4:52 Dennis Clarke
2020-04-19 5:35 ` Junio C Hamano
0 siblings, 1 reply; 6+ messages in thread
From: Dennis Clarke @ 2020-04-19 4:52 UTC (permalink / raw)
To: git
Very minor patch required :
--- ./compat/inet_ntop.c.orig Tue Apr 14 01:51:03 2020
+++ ./compat/inet_ntop.c Sun Apr 19 04:16:39 2020
@@ -168,7 +168,7 @@
* Paul Vixie, 1996.
*/
const char *
-inet_ntop(int af, const void *src, char *dst, size_t size)
+inet_ntop(int af, const void *src, char *dst, unsigned int size)
{
switch (af) {
case AF_INET:
--- ./git-compat-util.h.orig Tue Apr 14 01:51:03 2020
+++ ./git-compat-util.h Sun Apr 19 03:56:17 2020
@@ -795,7 +795,7 @@
#endif
#ifdef NO_INET_NTOP
-const char *inet_ntop(int af, const void *src, char *dst, size_t size);
+const char *inet_ntop(int af, const void *src, char *dst, unsigned int
size);
#endif
#ifdef NO_PTHREADS
#
# exit
That allows compile to proceed beatly with :
alpha$
alpha$ cc -V
cc: Studio 12.6 Sun C 5.15 SunOS_sparc 2017/05/30
--
Dennis Clarke
RISC-V/SPARC/PPC/ARM/CISC
UNIX and Linux spoken
GreyBeard and suspenders optional
^ permalink raw reply [flat|nested] 6+ messages in thread* Re: minor patch required to compile git 2.26.1 on Oracle Solaris 10 with Oracle Studio
2020-04-19 4:52 minor patch required to compile git 2.26.1 on Oracle Solaris 10 with Oracle Studio Dennis Clarke
@ 2020-04-19 5:35 ` Junio C Hamano
2020-04-22 8:09 ` Jeff King
0 siblings, 1 reply; 6+ messages in thread
From: Junio C Hamano @ 2020-04-19 5:35 UTC (permalink / raw)
To: Dennis Clarke; +Cc: git
Dennis Clarke <dclarke@blastwave.org> writes:
> Very minor patch required :
But both size_t and unsigned int are wrong types, no? Shouldn't we
be using socklen_t (and we seem to have autoconf support to figure
out an appropriate socklen_t fallback typedef)?
> --- ./compat/inet_ntop.c.orig Tue Apr 14 01:51:03 2020
> +++ ./compat/inet_ntop.c Sun Apr 19 04:16:39 2020
> @@ -168,7 +168,7 @@
> * Paul Vixie, 1996.
> */
> const char *
> -inet_ntop(int af, const void *src, char *dst, size_t size)
> +inet_ntop(int af, const void *src, char *dst, unsigned int size)
> {
> switch (af) {
> case AF_INET:
> --- ./git-compat-util.h.orig Tue Apr 14 01:51:03 2020
> +++ ./git-compat-util.h Sun Apr 19 03:56:17 2020
> @@ -795,7 +795,7 @@
> #endif
>
> #ifdef NO_INET_NTOP
> -const char *inet_ntop(int af, const void *src, char *dst, size_t size);
> +const char *inet_ntop(int af, const void *src, char *dst, unsigned
> int size);
> #endif
>
> #ifdef NO_PTHREADS
> #
> # exit
>
> That allows compile to proceed beatly with :
>
> alpha$
> alpha$ cc -V
> cc: Studio 12.6 Sun C 5.15 SunOS_sparc 2017/05/30
^ permalink raw reply [flat|nested] 6+ messages in thread* Re: minor patch required to compile git 2.26.1 on Oracle Solaris 10 with Oracle Studio
2020-04-19 5:35 ` Junio C Hamano
@ 2020-04-22 8:09 ` Jeff King
2020-04-22 8:11 ` Jeff King
0 siblings, 1 reply; 6+ messages in thread
From: Jeff King @ 2020-04-22 8:09 UTC (permalink / raw)
To: Junio C Hamano; +Cc: Dennis Clarke, git
On Sat, Apr 18, 2020 at 10:35:45PM -0700, Junio C Hamano wrote:
> Dennis Clarke <dclarke@blastwave.org> writes:
>
> > Very minor patch required :
>
> But both size_t and unsigned int are wrong types, no? Shouldn't we
> be using socklen_t (and we seem to have autoconf support to figure
> out an appropriate socklen_t fallback typedef)?
That is generally the right type according to POSIX, but I think there's
something even more subtle going on. If we're defining our own
inet_ntop(), then the type shouldn't really matter, should it?
Dennis didn't show us the compiler errors, but my suspicion is that it
is complaining because it is seeing the definition of inet_ntop()
already from a system header, and ours does not match.
Which implies that NO_INET_NTOP should not be set in the first place.
I think this is the same issue discussed in:
https://lore.kernel.org/git/CAH8yC8m3JFvEcfFF3z1rrRnEPK-adHGObmkOhNZiph7QJKUWqA@mail.gmail.com/
with a patch (which needs at least a signoff added) in:
https://lore.kernel.org/git/CAH8yC8kaWXbN+RYMJnM9em7KKW54+N07JtyS1MZk0qppD=m2BA@mail.gmail.com/
Dennis, does building with:
make NO_INET_NTOP= NO_INET_PTON=
help?
-Peff
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: minor patch required to compile git 2.26.1 on Oracle Solaris 10 with Oracle Studio
2020-04-22 8:09 ` Jeff King
@ 2020-04-22 8:11 ` Jeff King
2020-04-23 0:09 ` Dennis Clarke
0 siblings, 1 reply; 6+ messages in thread
From: Jeff King @ 2020-04-22 8:11 UTC (permalink / raw)
To: Junio C Hamano; +Cc: Jeffrey Walton, Dennis Clarke, git
On Wed, Apr 22, 2020 at 04:09:50AM -0400, Jeff King wrote:
> Which implies that NO_INET_NTOP should not be set in the first place.
> I think this is the same issue discussed in:
>
> https://lore.kernel.org/git/CAH8yC8m3JFvEcfFF3z1rrRnEPK-adHGObmkOhNZiph7QJKUWqA@mail.gmail.com/
>
> with a patch (which needs at least a signoff added) in:
>
> https://lore.kernel.org/git/CAH8yC8kaWXbN+RYMJnM9em7KKW54+N07JtyS1MZk0qppD=m2BA@mail.gmail.com/
>
> Dennis, does building with:
>
> make NO_INET_NTOP= NO_INET_PTON=
>
> help?
Sorry, I meant to cc Jeffrey Walton from that thread but forgot to.
Doing so now.
-Peff
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: minor patch required to compile git 2.26.1 on Oracle Solaris 10 with Oracle Studio
2020-04-22 8:11 ` Jeff King
@ 2020-04-23 0:09 ` Dennis Clarke
2020-04-23 5:41 ` Kevin Daudt
0 siblings, 1 reply; 6+ messages in thread
From: Dennis Clarke @ 2020-04-23 0:09 UTC (permalink / raw)
To: Jeff King, Junio C Hamano; +Cc: Jeffrey Walton, git
On 2020-04-22 04:11, Jeff King wrote:
> On Wed, Apr 22, 2020 at 04:09:50AM -0400, Jeff King wrote:
>
>> Which implies that NO_INET_NTOP should not be set in the first place.
>> I think this is the same issue discussed in:
>>
>> https://lore.kernel.org/git/CAH8yC8m3JFvEcfFF3z1rrRnEPK-adHGObmkOhNZiph7QJKUWqA@mail.gmail.com/
>>
>> with a patch (which needs at least a signoff added) in:
>>
>> https://lore.kernel.org/git/CAH8yC8kaWXbN+RYMJnM9em7KKW54+N07JtyS1MZk0qppD=m2BA@mail.gmail.com/
>>
>> Dennis, does building with:
>>
>> make NO_INET_NTOP= NO_INET_PTON=
>>
I will give that a try today and see what happens. There seems to be a
2.26.2 release from yesterday and may as well get that going. What was
the changelog reason for the bump from 2.26.1 to 2.26.2 ?
Dennis
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: minor patch required to compile git 2.26.1 on Oracle Solaris 10 with Oracle Studio
2020-04-23 0:09 ` Dennis Clarke
@ 2020-04-23 5:41 ` Kevin Daudt
0 siblings, 0 replies; 6+ messages in thread
From: Kevin Daudt @ 2020-04-23 5:41 UTC (permalink / raw)
To: Dennis Clarke; +Cc: Jeff King, Junio C Hamano, Jeffrey Walton, git
On Wed, Apr 22, 2020 at 08:09:46PM -0400, Dennis Clarke wrote:
> On 2020-04-22 04:11, Jeff King wrote:
> > On Wed, Apr 22, 2020 at 04:09:50AM -0400, Jeff King wrote:
> >
> > > Which implies that NO_INET_NTOP should not be set in the first place.
> > > I think this is the same issue discussed in:
> > >
> > > https://lore.kernel.org/git/CAH8yC8m3JFvEcfFF3z1rrRnEPK-adHGObmkOhNZiph7QJKUWqA@mail.gmail.com/
> > >
> > > with a patch (which needs at least a signoff added) in:
> > >
> > > https://lore.kernel.org/git/CAH8yC8kaWXbN+RYMJnM9em7KKW54+N07JtyS1MZk0qppD=m2BA@mail.gmail.com/
> > >
> > > Dennis, does building with:
> > >
> > > make NO_INET_NTOP= NO_INET_PTON=
> > >
>
> I will give that a try today and see what happens. There seems to be a
> 2.26.2 release from yesterday and may as well get that going. What was the
> changelog reason for the bump from 2.26.1 to 2.26.2 ?
>
> Dennis
>
>
Hello Dennis,
There was another CVE disclosed:
https://lore.kernel.org/git/xmqq4kterq5s.fsf@gitster.c.googlers.com/
Kind regards, Kevin
^ permalink raw reply [flat|nested] 6+ messages in thread
end of thread, other threads:[~2020-04-23 5:41 UTC | newest]
Thread overview: 6+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2020-04-19 4:52 minor patch required to compile git 2.26.1 on Oracle Solaris 10 with Oracle Studio Dennis Clarke
2020-04-19 5:35 ` Junio C Hamano
2020-04-22 8:09 ` Jeff King
2020-04-22 8:11 ` Jeff King
2020-04-23 0:09 ` Dennis Clarke
2020-04-23 5:41 ` Kevin Daudt
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).