git.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Jeff King <peff@peff.net>
To: "brian m. carlson" <sandals@crustytoothpaste.net>
Cc: Paul Smith <paul@mad-scientist.net>, Git List <git@vger.kernel.org>
Subject: Re: Git configure with static curl is failing
Date: Sun, 26 Apr 2020 19:14:10 -0400	[thread overview]
Message-ID: <20200426231410.GA1702090@coredump.intra.peff.net> (raw)
In-Reply-To: <20200426194729.GD6421@camp.crustytoothpaste.net>

On Sun, Apr 26, 2020 at 07:47:29PM +0000, brian m. carlson wrote:

> On 2020-04-26 at 19:01:54, Paul Smith wrote:
> > The problem appears to be that configure.ac is not using curl-config to
> > obtain the correct options to link with curl.  If I run
> > /other/curl/bin/curl-config --lib I get the proper flags:
> > 
> >   $ /other/curl/bin/curl-config --libs
> >   -L/other/curl/lib -lcurl -lssl -lz -lcrypto -ldl -lpthread
> > 
> > If configure.ac tried to use $CURLDIR/bin/curl-config --libs to obtain
> > the right linker options, then the link test for curl would work.
> 
> It doesn't surprise me that configure.ac doesn't use curl-config.  The
> configure script is generally not used by the main developers in favor
> of just using the makefile itself.
> 
> While we should fix that, the makefile does use curl-config, so if you
> just use it with any appropriate options without running configure, it
> will probably work for you.

Usually, yes, though it doesn't use `curl-config --cflags` properly. See
the series at [1]. What's there now, though might be enough for Paul's
case (if it's just a link-time issue).

I do think the autoconf code could do a better job of using curl-config,
along with a few other improvements. I left some thoughts in that
thread.

-Peff

[1] https://lore.kernel.org/git/20200326080540.GA2200522@coredump.intra.peff.net/

  reply	other threads:[~2020-04-26 23:14 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-04-26 19:01 Git configure with static curl is failing Paul Smith
2020-04-26 19:47 ` brian m. carlson
2020-04-26 23:14   ` Jeff King [this message]
2020-04-29  1:47     ` Paul Smith

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20200426231410.GA1702090@coredump.intra.peff.net \
    --to=peff@peff.net \
    --cc=git@vger.kernel.org \
    --cc=paul@mad-scientist.net \
    --cc=sandals@crustytoothpaste.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).