From: Jeff King <peff@peff.net>
To: Andreas Schwab <schwab@linux-m68k.org>
Cc: Junio C Hamano <gitster@pobox.com>,
douglas.fuller@gmail.com, git@vger.kernel.org
Subject: Re: [PATCH 1/2] gitcredentials(7): clarify quoting of helper examples
Date: Fri, 1 May 2020 03:31:13 -0400 [thread overview]
Message-ID: <20200501073113.GA27392@coredump.intra.peff.net> (raw)
In-Reply-To: <87tv10i0ll.fsf@linux-m68k.org>
On Fri, May 01, 2020 at 09:19:18AM +0200, Andreas Schwab wrote:
> On Mai 01 2020, Jeff King wrote:
>
> > # or you can specify your own shell snippet
> > -!f() { echo "password=`cat $HOME/.secret`"; }; f
> > +[credential]
> > +helper = "!f() { echo password=$(cat $HOME/.secret); }; f"
>
> That now lacks a pair of quotes around the argument of echo.
Right, as discussed in the commit message.
-Peff
next prev parent reply other threads:[~2020-05-01 7:31 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-04-30 14:36 [PATCH] doc: fix quoting bug in credential cache example douglas.fuller
2020-04-30 18:09 ` Junio C Hamano
2020-05-01 5:57 ` Jeff King
2020-05-01 6:19 ` Jeff King
2020-05-01 6:20 ` [PATCH 1/2] gitcredentials(7): clarify quoting of helper examples Jeff King
2020-05-01 7:19 ` Andreas Schwab
2020-05-01 7:31 ` Jeff King [this message]
2020-05-01 6:23 ` [PATCH 2/2] gitcredentials(7): make shell-snippet example more realistic Jeff King
2020-05-01 6:26 ` Junio C Hamano
2020-05-01 6:32 ` Jeff King
2020-05-01 6:35 ` Jeff King
2020-05-01 7:32 ` Jeff King
2020-05-01 7:33 ` [PATCH v2 1/2] gitcredentials(7): clarify quoting of helper examples Jeff King
2020-05-01 7:33 ` [PATCH v2 2/2] gitcredentials(7): make shell-snippet example more realistic Jeff King
2020-05-01 15:11 ` [PATCH " Junio C Hamano
2020-05-01 14:40 ` [PATCH] doc: fix quoting bug in credential cache example douglas.fuller
2020-05-01 6:20 ` Junio C Hamano
2020-05-01 6:25 ` Jeff King
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200501073113.GA27392@coredump.intra.peff.net \
--to=peff@peff.net \
--cc=douglas.fuller@gmail.com \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
--cc=schwab@linux-m68k.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).