From: Taylor Blau <me@ttaylorr.com>
To: Junio C Hamano <gitster@pobox.com>
Cc: Jeff King <peff@peff.net>, clime <clime7@gmail.com>,
Git List <git@vger.kernel.org>
Subject: Re: [PATCH 2/2] ref-filter: apply fallback refname sort only after all user sorts
Date: Mon, 4 May 2020 18:14:55 -0600 [thread overview]
Message-ID: <20200505001455.GA64230@syl.local> (raw)
In-Reply-To: <xmqqd07jfm2b.fsf@gitster.c.googlers.com>
On Mon, May 04, 2020 at 02:05:16PM -0700, Junio C Hamano wrote:
> Jeff King <peff@peff.net> writes:
>
> > Commit 9e468334b4 (ref-filter: fallback on alphabetical comparison,
> > 2015-10-30) taught ref-filter's sort to fallback to comparing refnames.
> > But it did it at the wrong level, overriding the comparison result for a
> > single "--sort" key from the user, rather than after all sort keys have
> > been exhausted.
>
> Good find. It does look like that the fallback was broken from the
> very first version when it was introduced, as we did have multiple
> keys support back in that version already.
>
> The fix looks good to me.
Me too.
Reviewed-by: Taylor Blau <me@ttaylorr.com>
> Thanks.
Thanks,
Taylor
next prev parent reply other threads:[~2020-05-05 0:15 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-05-02 20:31 git for-each-ref - sorting by multiple keys clime
2020-05-03 9:09 ` Jeff King
2020-05-03 9:11 ` [PATCH 1/2] ref-filter: apply --ignore-case to all sorting keys Jeff King
2020-05-03 11:44 ` Danh Doan
2020-05-04 15:13 ` Jeff King
2020-05-04 15:37 ` Junio C Hamano
2020-05-04 16:07 ` [PATCH] CodingGuidelines: drop arithmetic expansion advice to use "$x" Jeff King
2020-05-04 16:28 ` Carlo Marcelo Arenas Belón
2020-05-04 16:33 ` Jeff King
2020-05-04 19:47 ` Junio C Hamano
2020-05-04 23:32 ` Danh Doan
2020-05-05 20:40 ` Junio C Hamano
2020-05-05 21:07 ` Jeff King
2020-05-05 21:30 ` Junio C Hamano
2020-05-04 21:00 ` [PATCH 1/2] ref-filter: apply --ignore-case to all sorting keys Junio C Hamano
2020-05-05 0:11 ` Jeff King
2020-05-05 0:13 ` Taylor Blau
2020-05-03 9:13 ` [PATCH 2/2] ref-filter: apply fallback refname sort only after all user sorts Jeff King
2020-05-04 21:05 ` Junio C Hamano
2020-05-05 0:14 ` Taylor Blau [this message]
2020-05-03 10:16 ` git for-each-ref - sorting by multiple keys clime
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200505001455.GA64230@syl.local \
--to=me@ttaylorr.com \
--cc=clime7@gmail.com \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
--cc=peff@peff.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).