Git development
 help / color / mirror / Atom feed
From: "Carlo Marcelo Arenas Belón" <carenas@gmail.com>
To: "brian m. carlson" <sandals@crustytoothpaste.net>
Cc: git@vger.kernel.org, Jeff King <peff@peff.net>
Subject: Re: [PATCH] docs: document credential.helper allowed values
Date: Tue, 5 May 2020 17:30:29 -0700	[thread overview]
Message-ID: <20200506003029.GB49541@Carlos-MBP> (raw)
In-Reply-To: <20200505231226.1280264-1-sandals@crustytoothpaste.net>

On Tue, May 05, 2020 at 11:12:26PM +0000, brian m. carlson wrote:
> gitcredentials(7) already mentions several possible invocations that one
> can use as the value for credential.helper.  However, many people are
> not aware that there are other options than a simple credential helper
> name, so let's place some explanatory text in the documentation for
> credential.helper as well.
> 
> We still refer the user to gitcredential(7) for additional explanations
> and helpful examples.
> 
> Signed-off-by: brian m. carlson <sandals@crustytoothpaste.net>
> ---
>  Documentation/config/credential.txt | 10 +++++++---
>  1 file changed, 7 insertions(+), 3 deletions(-)
> 
> diff --git a/Documentation/config/credential.txt b/Documentation/config/credential.txt
> index 60fb3189e1..9d01641c28 100644
> --- a/Documentation/config/credential.txt
> +++ b/Documentation/config/credential.txt
> @@ -1,9 +1,13 @@
>  credential.helper::
>  	Specify an external helper to be called when a username or
>  	password credential is needed; the helper may consult external
> -	storage to avoid prompting the user for the credentials. Note
> -	that multiple helpers may be defined. See linkgit:gitcredentials[7]
> -	for details.
> +	storage to avoid prompting the user for the credentials. This is
> +	normally the name of a credential helper with possible
> +	arguments, but may also be an absolute path with arguments or, if
> +	preceded by `!`, shell commands.
> ++
> +Note that multiple helpers may be defined. See linkgit:gitcredentials[7]
> +for details and examples.

what about something even simpler, to encourage people to go see the full
range of options and hopeful find a fitting example in gitcredentials?

  "This is usually a credential helper application with possible arguments
   but might also be a simple shell one liner for the simplest uses"

with the Note following as you suggested.
 
Carlo

PS. I suspect a sample like the one you provided for smtp would be very
    useful there, specially if using an encrypted storage of sort.

  reply	other threads:[~2020-05-06  0:30 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-05-05 23:12 [PATCH] docs: document credential.helper allowed values brian m. carlson
2020-05-06  0:30 ` Carlo Marcelo Arenas Belón [this message]
2020-05-06 16:27 ` Jeff King

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20200506003029.GB49541@Carlos-MBP \
    --to=carenas@gmail.com \
    --cc=git@vger.kernel.org \
    --cc=peff@peff.net \
    --cc=sandals@crustytoothpaste.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox