From: Taylor Blau <me@ttaylorr.com>
To: Claus Schneider <claus.schneider@eficode.com>
Cc: git@vger.kernel.org
Subject: Re: [RFC] subtree: use say and exit 0 rather than die in case of no new revision found scenario
Date: Wed, 6 May 2020 11:37:13 -0600 [thread overview]
Message-ID: <20200506173713.GD6078@syl.local> (raw)
In-Reply-To: <CA+GP4brpeGhBy3LF0LomDO-AOEZS02tOi2phQ4e1XoTGgeAx2w@mail.gmail.com>
Hi Claus,
On Wed, May 06, 2020 at 03:11:49PM +0200, Claus Schneider wrote:
> Hi..
>
> Currently subtree dies if "No new revisions found" which is hard as it
> is a non-operation.
>
> I suggest using the "say" command rather than "die".
>
> It will then become easier just to call "git subtree split" and you do
> not need to handle this special case.
>
> Patches can be found here:
> https://github.com/git/git/commit/fe435a1ba128698f6acb69ee1891c45be32610fa
Thanks for your patch. The Git mailing list reviews patches over email,
so please re-submit this (and the other two patches) you sent to the
list here.
Detailed guidelines on how to do that are here:
https://github.com/git/git/blob/master/Documentation/SubmittingPatches
and
https://github.com/git/git/blob/master/Documentation/MyFirstContribution.txt
Alternatively, you may use GitGitGadget, which makes it convenient to
send patches to the mailing list from GitHub's UI. More information
about that may be found here: https://gitgitgadget.github.io/.
> Best regards
> Claus Schneider
Thanks,
Taylor
prev parent reply other threads:[~2020-05-06 17:37 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <CA+GP4boTMaShBbJUQUA0GThpXXPiCQHFGKFYUYLE3mbsjSdqTw@mail.gmail.com>
[not found] ` <CA+GP4boXi4tW23Z6CDF2v_ch2_7_dqhB_POAhi1FfYrEBG4DWQ@mail.gmail.com>
2020-05-06 13:11 ` [RFC] subtree: use say and exit 0 rather than die in case of no new revision found scenario Claus Schneider
2020-05-06 17:37 ` Taylor Blau [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200506173713.GD6078@syl.local \
--to=me@ttaylorr.com \
--cc=claus.schneider@eficode.com \
--cc=git@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).