git.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Junio C Hamano <gitster@pobox.com>
To: git@vger.kernel.org
Subject: [PATCH 0/2] Pass down "--quiet" to "gc --auto"
Date: Wed,  6 May 2020 13:18:28 -0700	[thread overview]
Message-ID: <20200506201830.92818-1-gitster@pobox.com> (raw)
In-Reply-To: <20200506094327.GC31637@rillettes>

A handful commands take "--quiet" from their command line,
but forgets to pass it down, when they trigger an auto gc,
to the "git gc --auto" they internally invoke.

Back in 1991006c (fetch: convert argv_gc_auto to struct argv_array,
2014-08-16), we patched "git fetch" but seems to have forgotten
doing the same for "git merge".  Since then, rewrite of "git am" and
"git rebase" in C spread the same problem into two more codepaths.

Let's clean them up once and for all.

Junio C Hamano (2):
  run_auto_gc(): extract a reusable helper
  auto-gc: pass --quiet down from am, commit, merge and rebase

 builtin/am.c     |  3 +--
 builtin/commit.c |  3 +--
 builtin/fetch.c  | 10 ++--------
 builtin/merge.c  |  3 +--
 builtin/rebase.c |  3 +--
 run-command.c    | 13 +++++++++++++
 run-command.h    |  5 +++++
 7 files changed, 24 insertions(+), 16 deletions(-)

-- 
2.26.2-561-g07d8ea56f2


  parent reply	other threads:[~2020-05-06 20:18 UTC|newest]

Thread overview: 13+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-05-06  9:43 option -q not passed from "git commit" to "git gc --auto" Pierrick Gaudry
2020-05-06 17:28 ` Taylor Blau
2020-05-06 17:33   ` Taylor Blau
2020-05-06 17:38     ` Taylor Blau
2020-05-06 17:31 ` Junio C Hamano
2020-05-06 18:56   ` Re* " Junio C Hamano
2020-05-06 19:03     ` [PATCH 2/2] auto-gc: pass --quiet down from am, commit, merge and rebase Junio C Hamano
2020-05-06 19:27       ` Junio C Hamano
2020-05-06 20:18 ` Junio C Hamano [this message]
2020-05-06 20:18   ` [PATCH 1/2] auto-gc: extract a reusable helper from "git fetch" Junio C Hamano
2020-05-06 20:18   ` [PATCH 2/2] auto-gc: pass --quiet down from am, commit, merge and rebase Junio C Hamano
2020-05-07 17:22     ` Taylor Blau
2020-05-07 19:31       ` Junio C Hamano

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20200506201830.92818-1-gitster@pobox.com \
    --to=gitster@pobox.com \
    --cc=git@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).