From: "Carlo Marcelo Arenas Belón" <carenas@gmail.com>
To: git@vger.kernel.org
Cc: emaste@freebsd.org, sunshine@sunshineco.com, gitster@pobox.com,
"Carlo Marcelo Arenas Belón" <carenas@gmail.com>
Subject: [PATCH v3 0/2] auto detect REG_ILLSEQ
Date: Mon, 18 May 2020 11:44:14 -0700 [thread overview]
Message-ID: <20200518184416.13882-1-carenas@gmail.com> (raw)
In-Reply-To: <20200515195157.41217-1-carenas@gmail.com>
This is a reroll for cb/t4210-illseq-auto-detect that includes all
feedback and split on two steps for easy of reviewing.
While the refactoring in test-regex.c is a little more intrusive that
needed, makes the logic easier to follow and the different use cases
more straightforward.
Note that there is still a leak in the use of regex_t, and had kept
all original assumptions for simplicity (no explicit check on REG_ILLSEQ,
or unlikely differences between BASIC/EXTENDED).
Carlo Marcelo Arenas Belón (2):
t/helper: teach test-regex to report pattern errors (like REG_ILLSEQ)
t4210: detect REG_ILLSEQ dynamically and skip affected tests
t/helper/test-regex.c | 94 ++++++++++++++++++++++++++++++-------------
t/t4210-log-i18n.sh | 77 ++++++++++++++++++++++++++---------
t/test-lib.sh | 6 ---
3 files changed, 125 insertions(+), 52 deletions(-)
--
2.27.0.rc0.183.gde8f92d652
next prev parent reply other threads:[~2020-05-18 18:44 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-05-13 11:16 [PATCH] t4210: detect REG_ILLSEQ dynamically Carlo Marcelo Arenas Belón
2020-05-13 15:44 ` Eric Sunshine
2020-05-13 16:20 ` Junio C Hamano
2020-05-13 20:18 ` Carlo Marcelo Arenas Belón
2020-05-13 20:37 ` Junio C Hamano
2020-05-13 21:04 ` Carlo Marcelo Arenas Belón
2020-05-13 18:02 ` [RFC PATCH v2] " Carlo Marcelo Arenas Belón
2020-05-13 20:40 ` Eric Sunshine
2020-05-15 18:00 ` Junio C Hamano
2020-05-15 18:18 ` Carlo Marcelo Arenas Belón
2020-05-15 19:51 ` [PATCH " Carlo Marcelo Arenas Belón
2020-05-15 20:24 ` Junio C Hamano
2020-05-15 21:48 ` Junio C Hamano
2020-05-18 18:44 ` Carlo Marcelo Arenas Belón [this message]
2020-05-18 18:44 ` [PATCH v3 1/2] t/helper: teach test-regex to report pattern errors (like REG_ILLSEQ) Carlo Marcelo Arenas Belón
2020-05-18 20:15 ` Junio C Hamano
2020-05-18 18:44 ` [PATCH v3 2/2] t4210: detect REG_ILLSEQ dynamically and skip affected tests Carlo Marcelo Arenas Belón
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200518184416.13882-1-carenas@gmail.com \
--to=carenas@gmail.com \
--cc=emaste@freebsd.org \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
--cc=sunshine@sunshineco.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).