git.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Jeff King <peff@peff.net>
To: Noel Grandin <noelgrandin@gmail.com>
Cc: Git List <git@vger.kernel.org>
Subject: Re: filtering on git fetch?
Date: Wed, 17 Jun 2020 07:32:34 -0400	[thread overview]
Message-ID: <20200617113234.GA703467@coredump.intra.peff.net> (raw)
In-Reply-To: <e3ec6fec-b872-b548-0eb0-d085ca36c99b@gmail.com>

On Wed, Jun 17, 2020 at 10:42:24AM +0200, Noel Grandin wrote:

> I tried (BTW my version is 2.26.2)
> 
> $ GIT_TRACE_PACKET=1 git -c protocol.version=2 pull -r

Ah, yeah, I think it should be the default in that version anyway.

> and the first few lines look like
> 
> 10:35:59.323490 pkt-line.c:80           packet:        fetch<
> ad0351b84926075297fb74abbe9b31a0455782af HEAD\0 include-tag
> multi_ack_detailed multi_ack o
> fs-delta side-band side-band-64k thin-pack no-progress shallow agent=JGit/5.3.7.202002110540-r symref=HEAD:refs/heads/master

Yep, that's definitely v0.

> Is there something else I need to do on the client-side to make this work?

No, probably the server doesn't support v2. I double-checked myself, and
couldn't get it to speak v2 either.

> Noting that the git server at gerrit.libreoffice.org might be a JGit based
> thing, so maybe I need to log a feature request there to support v2?

Probably.  I'm fairly certain that JGit has supported v2 for a while.
Just poking at `git log` in jgit.git shows some commits adding it around
the 5.0 timeframe. So I'd think the version they're advertising would
have it. I don't know offhand if there's a config option they'd need to
flip on the server.

-Peff

      reply	other threads:[~2020-06-17 11:32 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-06-17  7:41 filtering on git fetch? Noel Grandin
2020-06-17  8:34 ` Jeff King
2020-06-17  8:42   ` Noel Grandin
2020-06-17 11:32     ` Jeff King [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20200617113234.GA703467@coredump.intra.peff.net \
    --to=peff@peff.net \
    --cc=git@vger.kernel.org \
    --cc=noelgrandin@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).