Git development
 help / color / mirror / Atom feed
From: Jeff King <peff@peff.net>
To: Fabio Frumento <frumento.fabio@gmail.com>
Cc: git@vger.kernel.org
Subject: Re: Built Git 2.27.0 from sources on macOS Catalina fails on "make profile"
Date: Wed, 1 Jul 2020 11:37:26 -0400	[thread overview]
Message-ID: <20200701153726.GC6726@coredump.intra.peff.net> (raw)
In-Reply-To: <618374D7-60E1-4942-B29F-4F2EA261996F@gmail.com>

On Wed, Jul 01, 2020 at 03:17:05PM +0200, Fabio Frumento wrote:

> now I'm struggling during the ```make profile``` step
> [...]
> I'm a little surprised as presumed, since 2.27.0 is an official
> release, all the tests should pass without any issue.

They generally do (not just for releases but for every commit that hits
master). However, we've sometimes seen weird test failures from "make
profile" (which in my experience isn't all that well maintained).

That said, "make profile" passes for me on v2.27.0, on Linux.  It's
possible that a test is racy (the profiler often slows things down,
exacerbating races), but I can't seem to get t0410 to fail with our
usual stress-test to find races.

If you don't care about profile-optimized builds, then I'd suggest
skipping "make profile".

If you want to look further into the test failure, probably it would
help to re-run the test with more verbose settings. E.g.:

  [wait for this to fail, which would leave the problematic version of
   git in the build directory]
  $ make profile
  $ cd t
  $ ./t0410-partial-clone.sh -v -i -x

then we could see what's failing.

> How to file a bug to the Git developers?

I think you just did.

-Peff

  reply	other threads:[~2020-07-01 15:37 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-07-01 13:17 Built Git 2.27.0 from sources on macOS Catalina fails on "make profile" Fabio Frumento
2020-07-01 15:37 ` Jeff King [this message]
2020-07-01 16:00   ` Fabio Frumento
2020-07-01 16:10     ` Jeff King
2020-07-01 16:14       ` Fabio Frumento

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20200701153726.GC6726@coredump.intra.peff.net \
    --to=peff@peff.net \
    --cc=frumento.fabio@gmail.com \
    --cc=git@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox