git.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Jonathan Nieder <jrnieder@gmail.com>
To: Junio C Hamano <gitster@pobox.com>
Cc: Taylor Blau <me@ttaylorr.com>,
	git@vger.kernel.org, Derrick Stolee <dstolee@microsoft.com>,
	Jonathan Tan <jonathantanmy@google.com>
Subject: Re: [PATCH] experimental: default to fetch.writeCommitGraph=false
Date: Tue, 7 Jul 2020 22:47:25 -0700	[thread overview]
Message-ID: <20200708054725.GB118756@google.com> (raw)
In-Reply-To: <xmqqeepn5kxz.fsf@gitster.c.googlers.com>

Junio C Hamano wrote:

> We could obviously do both excluding it from the usual experimental
> set and applying your fix, so that those who are really curious can
> help us make sure your fix would be all that is needed.  Let's see
> what Jonathan says...

Yes, that would be my preference.

That is, both:

* applying the fix to provide a good experience to users interested in
  fetch.writeCommitGraph

* disabling fetch.writeCommitGraph in the experimental set, since it
  has not had much production exposure yet.  The experimental set is
  relatively young, so I want to ensure people's initial experiences
  with it are positive so that they stick with it if they're
  interested in experimental features (or in other words, I think
  there's still a place for features that are not yet proven enough
  to go in the experimental set).

Regardless of what is put in the experimental set, at $DAYJOB we will
run with the fix applied and with fetch.writeCommitGraph=true starting
next week.  I'd encourage anyone else with a similarly controlled
setup to try the same.

Thanks,
Jonathan

      parent reply	other threads:[~2020-07-08  5:47 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-07-07  6:20 [PATCH] experimental: default to fetch.writeCommitGraph=false Jonathan Nieder
2020-07-07 13:24 ` Derrick Stolee
2020-07-07 15:09 ` Junio C Hamano
2020-07-07 15:17   ` Taylor Blau
2020-07-07 16:50     ` Junio C Hamano
2020-07-07 16:53       ` Taylor Blau
2020-07-08  5:47       ` Jonathan Nieder [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20200708054725.GB118756@google.com \
    --to=jrnieder@gmail.com \
    --cc=dstolee@microsoft.com \
    --cc=git@vger.kernel.org \
    --cc=gitster@pobox.com \
    --cc=jonathantanmy@google.com \
    --cc=me@ttaylorr.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).