From: Jeff King <peff@peff.net>
To: "SZEDER Gábor" <szeder.dev@gmail.com>
Cc: Martian Chronicles <martian.chronicles@yandex.ru>,
git <git@vger.kernel.org>
Subject: Re: BUG: Cannot use bright colors
Date: Mon, 20 Jul 2020 13:13:56 -0400 [thread overview]
Message-ID: <20200720171356.GA2045458@coredump.intra.peff.net> (raw)
In-Reply-To: <20200720165535.GI11341@szeder.dev>
On Mon, Jul 20, 2020 at 06:55:35PM +0200, SZEDER Gábor wrote:
> On Mon, Jul 20, 2020 at 07:29:52PM +0300, Martian Chronicles wrote:
> > Cannot configure git to use brightred, neither on Windows nor on Ubuntu.
> >
> > Steps to reproduce:
> >
> > 1. Create ~/.gitconfig with the two lines (or add to them to this file, if it exists):
> >
> > [color.status]
> > untracked = brightred
> >
> > 2. run `git status` from a directory with untracked files
> >
> > Expected: output in brightred
> > Actual on Linux:
> > error: invalid color value: brightred fatal: bad config variable 'color.status.untracked' in file '/home/<username>/.gitconfig' at line 2
> >
> > Actual on windows:
> > brightred=normal=white.
>
> Bright colors are supported since v2.26.0. What Git version did you
> try?
It sounds like two different versions. :) If Git isn't complaining about
the color name on Windows, then it's probably sending out the correct
ANSI codes. But whether those do anything you can see depends on your
terminal emulator. I don't know what options there are on Windows.
For the Windows console, there's an extra stdio layer that handles these
ANSI codes. It looks like compat/mingw.c's set_attr() would need to be
updated, but from reading it, I'm not sure it would even support these
extra colors. Probably "bold red" is the best you could do.
-Peff
prev parent reply other threads:[~2020-07-20 17:13 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-07-20 16:29 BUG: Cannot use bright colors Martian Chronicles
2020-07-20 16:55 ` SZEDER Gábor
2020-07-20 17:13 ` Jeff King [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200720171356.GA2045458@coredump.intra.peff.net \
--to=peff@peff.net \
--cc=git@vger.kernel.org \
--cc=martian.chronicles@yandex.ru \
--cc=szeder.dev@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).