git.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
* BUG: Cannot use bright colors
@ 2020-07-20 16:29 Martian Chronicles
  2020-07-20 16:55 ` SZEDER Gábor
  0 siblings, 1 reply; 3+ messages in thread
From: Martian Chronicles @ 2020-07-20 16:29 UTC (permalink / raw)
  To: git

Cannot configure git to use brightred, neither on Windows nor on Ubuntu. 

Steps to reproduce: 

1. Create ~/.gitconfig with the two lines (or add to them to this file, if it exists):

[color.status]
        untracked = brightred

2. run `git status` from a directory with untracked files

Expected: output in brightred
Actual on Linux:
error: invalid color value: brightred fatal: bad config variable 'color.status.untracked' in file '/home/<username>/.gitconfig' at line 2 

Actual on windows:
 brightred=normal=white.

^ permalink raw reply	[flat|nested] 3+ messages in thread

* Re: BUG: Cannot use bright colors
  2020-07-20 16:29 BUG: Cannot use bright colors Martian Chronicles
@ 2020-07-20 16:55 ` SZEDER Gábor
  2020-07-20 17:13   ` Jeff King
  0 siblings, 1 reply; 3+ messages in thread
From: SZEDER Gábor @ 2020-07-20 16:55 UTC (permalink / raw)
  To: Martian Chronicles; +Cc: git

On Mon, Jul 20, 2020 at 07:29:52PM +0300, Martian Chronicles wrote:
> Cannot configure git to use brightred, neither on Windows nor on Ubuntu. 
> 
> Steps to reproduce: 
> 
> 1. Create ~/.gitconfig with the two lines (or add to them to this file, if it exists):
> 
> [color.status]
>         untracked = brightred
> 
> 2. run `git status` from a directory with untracked files
> 
> Expected: output in brightred
> Actual on Linux:
> error: invalid color value: brightred fatal: bad config variable 'color.status.untracked' in file '/home/<username>/.gitconfig' at line 2 
> 
> Actual on windows:
>  brightred=normal=white.

Bright colors are supported since v2.26.0.  What Git version did you
try?


^ permalink raw reply	[flat|nested] 3+ messages in thread

* Re: BUG: Cannot use bright colors
  2020-07-20 16:55 ` SZEDER Gábor
@ 2020-07-20 17:13   ` Jeff King
  0 siblings, 0 replies; 3+ messages in thread
From: Jeff King @ 2020-07-20 17:13 UTC (permalink / raw)
  To: SZEDER Gábor; +Cc: Martian Chronicles, git

On Mon, Jul 20, 2020 at 06:55:35PM +0200, SZEDER Gábor wrote:

> On Mon, Jul 20, 2020 at 07:29:52PM +0300, Martian Chronicles wrote:
> > Cannot configure git to use brightred, neither on Windows nor on Ubuntu. 
> > 
> > Steps to reproduce: 
> > 
> > 1. Create ~/.gitconfig with the two lines (or add to them to this file, if it exists):
> > 
> > [color.status]
> >         untracked = brightred
> > 
> > 2. run `git status` from a directory with untracked files
> > 
> > Expected: output in brightred
> > Actual on Linux:
> > error: invalid color value: brightred fatal: bad config variable 'color.status.untracked' in file '/home/<username>/.gitconfig' at line 2 
> > 
> > Actual on windows:
> >  brightred=normal=white.
> 
> Bright colors are supported since v2.26.0.  What Git version did you
> try?

It sounds like two different versions. :) If Git isn't complaining about
the color name on Windows, then it's probably sending out the correct
ANSI codes.  But whether those do anything you can see depends on your
terminal emulator. I don't know what options there are on Windows.

For the Windows console, there's an extra stdio layer that handles these
ANSI codes. It looks like compat/mingw.c's set_attr() would need to be
updated, but from reading it, I'm not sure it would even support these
extra colors. Probably "bold red" is the best you could do.

-Peff

^ permalink raw reply	[flat|nested] 3+ messages in thread

end of thread, other threads:[~2020-07-20 17:13 UTC | newest]

Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2020-07-20 16:29 BUG: Cannot use bright colors Martian Chronicles
2020-07-20 16:55 ` SZEDER Gábor
2020-07-20 17:13   ` Jeff King

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).