git.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Roland Hieber <rhi@pengutronix.de>
To: git@vger.kernel.org
Cc: Roland Hieber <rhi@pengutronix.de>,
	Vasco Almeida <vascomalmeida@sapo.pt>,
	Junio C Hamano <gitster@pobox.com>
Subject: [PATCH] bisect: allow to run from subdirectories
Date: Sun, 20 Jun 2021 23:38:37 +0200	[thread overview]
Message-ID: <20210620213836.10771-1-rhi@pengutronix.de> (raw)

Currently, calling 'git bisect' from a directory other than the top
level of a repository only comes up with an error message:

    You need to run this command from the toplevel of the working tree.

After a glance through the bisect code, there seems to be nothing that
relies on the current working directory, and a few hours of bisect usage
also didn't turn up any problems. Set the appropriate flag for
git-sh-setup to remove the error message.

Signed-off-by: Roland Hieber <rhi@pengutronix.de>
---
 git-bisect.sh | 1 +
 1 file changed, 1 insertion(+)

diff --git a/git-bisect.sh b/git-bisect.sh
index 6a7afaea8da0..20ba0ee7c18a 100755
--- a/git-bisect.sh
+++ b/git-bisect.sh
@@ -32,6 +32,7 @@ git bisect run <cmd>...
 Please use "git help bisect" to get the full man page.'
 
 OPTIONS_SPEC=
+SUBDIRECTORY_OK=1
 . git-sh-setup
 
 _x40='[0-9a-f][0-9a-f][0-9a-f][0-9a-f][0-9a-f]'
-- 
2.29.2


             reply	other threads:[~2021-06-20 21:39 UTC|newest]

Thread overview: 13+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-06-20 21:38 Roland Hieber [this message]
2021-06-21  0:35 ` [PATCH] bisect: allow to run from subdirectories Ævar Arnfjörð Bjarmason
2021-06-21  2:00   ` brian m. carlson
2021-06-21  2:10     ` Eric Sunshine
2021-06-21  9:33       ` Roland Hieber
2021-06-21 12:45         ` Ævar Arnfjörð Bjarmason
2021-06-21 20:02           ` Eric Sunshine
2021-06-22 15:27           ` Ævar Arnfjörð Bjarmason
2021-06-22  0:09       ` brian m. carlson
2021-06-21  3:43 ` Junio C Hamano
2021-06-23 23:40   ` Jeff King
2021-06-29  1:22     ` Junio C Hamano
2021-06-29  2:00       ` Jeff King

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20210620213836.10771-1-rhi@pengutronix.de \
    --to=rhi@pengutronix.de \
    --cc=git@vger.kernel.org \
    --cc=gitster@pobox.com \
    --cc=vascomalmeida@sapo.pt \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).