Re: [PATCH] bisect: allow to run from subdirectories

[Roland Hieber <rhi@pengutronix.de>]

On Sun, Jun 20, 2021 at 10:10:10PM -0400, Eric Sunshine wrote:
> On Sun, Jun 20, 2021 at 10:00 PM brian m. carlson
> <sandals@crustytoothpaste.net> wrote:
> > On 2021-06-21 at 00:35:49, Ævar Arnfjörð Bjarmason wrote:
> > > On Sun, Jun 20 2021, Roland Hieber wrote:
> > > > Currently, calling 'git bisect' from a directory other than the top
> > > > level of a repository only comes up with an error message:
> > > >
> > > >     You need to run this command from the toplevel of the working tree.
> > >
> > > How does this affect out-of-tree scripts that will be run with "git
> > > bisect run", is the cwd set to the root as they now might expect git to
> > > check, or whatever subdirectory you ran the "run" from?
> >
> > As for the idea itself, I think it's a good one assuming everything
> > continues to work.  It will certainly be more convenient for a lot of
> > people.
> 
> There have been multiple patches sent to the project over the years
> with the same purpose. One problem, I believe, which has never been
> fully addressed is what happens when the subdirectory from which
> git-bisect is run gets deleted as part of the bisection.
> 
> Here are a couple recent threads triggered by previous such patches
> (but there are probably several more):
> 
> https://lore.kernel.org/git/pull.765.git.1603271344522.gitgitgadget@gmail.com/
> https://lore.kernel.org/git/pull.736.git.git.1584868547682.gitgitgadget@gmail.com/

Ah, thanks for explaining the problem. Would a patch that adds a short
explanatory comment in git-bisect.sh on the matter help to prevent
people sending such patches?

 - Roland

-- 
Roland Hieber, Pengutronix e.K.          | r.hieber@pengutronix.de     |
Steuerwalder Str. 21                     | https://www.pengutronix.de/ |
31137 Hildesheim, Germany                | Phone: +49-5121-206917-0    |
Amtsgericht Hildesheim, HRA 2686         | Fax:   +49-5121-206917-5555 |